[M] Change in dart/sdk[main]: Enable recommended lints when verifying diagnostic documentation
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
3:57 PM (3 hours ago) 3:57 PM
to Brian Wilkerson, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
3:58 PM (3 hours ago) 3:58 PM
to Brian Wilkerson, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Brian Wilkerson voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Konstantin Shcheglov (Gerrit)
5:19 PM (2 hours ago) 5:19 PM
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Konstantin Shcheglov voted![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
5:20 PM (2 hours ago) 5:20 PM
to Brian Wilkerson, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Enable recommended lints when verifying diagnostic documentation
This enables the remainder of the recommended lints when verifying
diagnostic documentation. As before, in most cases this amounted to
ignoring additional diagnostics and documenting why I thought that was
a reasonable choice.
At some point someone should create issues for all of the places where
a diagnostic is being reported where it shouldn't be and add the URL
of the issue to these files.
Change-Id: Iadcad9f13334e3f1702a32273e190a04017796aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/532000
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Auto-Submit: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/messages.yaml
- M pkg/analyzer/test/verify_diagnostics_test.dart
- M pkg/linter/messages.yaml
Change size: M
Delta: 3 files changed, 83 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages