[M] Change in dart/sdk[main]: [DAS] Fixes part of `Convert Getter to Method` bug in pattern field r...

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Dec 1, 2025, 10:53:50 AM (yesterday) Dec 1
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes part of `Convert Getter to Method` bug in pattern field references
Change-Id: If6927e3a421e190baaade79032d980f12692d676

Change information

Files:
  • M pkg/analysis_server/lib/src/services/refactoring/legacy/convert_getter_to_method.dart
  • M pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_internal.dart
  • M pkg/analysis_server/lib/src/services/search/search_engine.dart
  • M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
  • M pkg/analysis_server/test/services/refactoring/legacy/convert_getter_to_method_test.dart
  • M pkg/analyzer/lib/src/dart/analysis/index.dart
  • M pkg/analyzer/lib/src/dart/analysis/search.dart
  • M pkg/analyzer/lib/src/summary/idl.dart
Change size: M
Delta: 8 files changed, 54 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If6927e3a421e190baaade79032d980f12692d676
Gerrit-Change-Number: 465360
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Dec 1, 2025, 10:58:50 AM (yesterday) Dec 1
to Samuel Rawlins, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry and Samuel Rawlins

Felipe Morschel added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Felipe Morschel . unresolved

I've asked on the issue, if anyone has any idea on how could we handle the local-variable references (that now need `()`):
https://github.com/dart-lang/sdk/issues/62139#issuecomment-3597354044

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Berry
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If6927e3a421e190baaade79032d980f12692d676
Gerrit-Change-Number: 465360
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 15:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Paul Berry (Gerrit)

unread,
Dec 1, 2025, 6:02:18 PM (17 hours ago) Dec 1
to Felipe Morschel, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins

Paul Berry voted and added 1 comment

Votes added by Paul Berry

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Paul Berry . resolved

pkg/analyzer changes lgtm. I'll let Sam look at the pkg/analysis_server changes.

Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
  • Samuel Rawlins
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: If6927e3a421e190baaade79032d980f12692d676
    Gerrit-Change-Number: 465360
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Mon, 01 Dec 2025 23:02:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Dec 1, 2025, 6:13:40 PM (17 hours ago) Dec 1
    to Felipe Morschel, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Felipe Morschel

    Samuel Rawlins voted and added 1 comment

    Votes added by Samuel Rawlins

    Code-Review+1

    1 comment

    Patchset-level comments
    Samuel Rawlins . resolved

    Fine impl, nice tests, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Morschel
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: If6927e3a421e190baaade79032d980f12692d676
    Gerrit-Change-Number: 465360
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Mon, 01 Dec 2025 23:13:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Felipe Morschel (Gerrit)

    unread,
    Dec 1, 2025, 7:22:51 PM (16 hours ago) Dec 1
    to Samuel Rawlins, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Paul Berry and Samuel Rawlins

    Felipe Morschel voted and added 1 comment

    Votes added by Felipe Morschel

    Auto-Submit+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2:
    Felipe Morschel . resolved

    I've fixed the broken bots. Thanks for running them!
    Everything should be fine now.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Paul Berry
    • Samuel Rawlins
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: If6927e3a421e190baaade79032d980f12692d676
      Gerrit-Change-Number: 465360
      Gerrit-PatchSet: 2
      Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Reviewer: Paul Berry <paul...@google.com>
      Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
      Gerrit-Attention: Paul Berry <paul...@google.com>
      Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
      Gerrit-Comment-Date: Tue, 02 Dec 2025 00:22:48 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      open
      diffy

      Samuel Rawlins (Gerrit)

      unread,
      Dec 1, 2025, 9:06:39 PM (14 hours ago) Dec 1
      to Felipe Morschel, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
      Attention needed from Felipe Morschel and Paul Berry

      Samuel Rawlins voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Felipe Morschel
      • Paul Berry
      Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: If6927e3a421e190baaade79032d980f12692d676
        Gerrit-Change-Number: 465360
        Gerrit-PatchSet: 3
        Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
        Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
        Gerrit-Reviewer: Paul Berry <paul...@google.com>
        Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
        Gerrit-Attention: Paul Berry <paul...@google.com>
        Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
        Gerrit-Comment-Date: Tue, 02 Dec 2025 02:06:36 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages