[S] Change in dart/sdk[main]: [co19] Roll co19 to 46c52754a2033f5127f01ea4e0df0e8a3f934cb6

3 views
Skip to first unread message

Erik Ernst (Gerrit)

unread,
Aug 8, 2025, 4:16:22 AM8/8/25
to Sergey Grekhov, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
Gerrit-Change-Number: 444282
Gerrit-PatchSet: 2
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 08:16:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Aug 8, 2025, 5:14:33 AM8/8/25
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
Gerrit-Change-Number: 444282
Gerrit-PatchSet: 3
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 09:14:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sergey Grekhov (Gerrit)

unread,
Aug 8, 2025, 5:54:54 AM8/8/25
to Erik Ernst, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Sergey Grekhov . resolved

Can be landed.
Analyzer failures caused by https://github.com/dart-lang/sdk/issues/54366
Other failures:
co19/LibTest/js_interop/JS/js_A01_t04 - https://github.com/dart-lang/sdk/issues/61205
co19/LibTest/js_interop/JS/js_A01_t10 - https://github.com/dart-lang/sdk/issues/61208
co19/LibTest/js_interop/JS/js_A01_t11 - https://github.com/dart-lang/sdk/issues/61208
co19/LibTest/js_interop/JS/js_A01_t12 - https://github.com/dart-lang/sdk/issues/61208
co19/LibTest/js_interop/JS/js_A01_t16 - https://github.com/dart-lang/sdk/issues/61208

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
Gerrit-Change-Number: 444282
Gerrit-PatchSet: 3
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 09:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Thomas (Gerrit)

unread,
Aug 11, 2025, 3:01:28 AM8/11/25
to Sergey Grekhov, Erik Ernst, Commit Queue, rev...@dartlang.org
Attention needed from Sergey Grekhov

Alexander Thomas voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sergey Grekhov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
    Gerrit-Change-Number: 444282
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 07:01:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alexander Thomas (Gerrit)

    unread,
    Aug 11, 2025, 3:01:36 AM8/11/25
    to Sergey Grekhov, Erik Ernst, Commit Queue, rev...@dartlang.org
    Attention needed from Sergey Grekhov

    Alexander Thomas voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sergey Grekhov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
    Gerrit-Change-Number: 444282
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 07:01:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Aug 11, 2025, 3:41:30 AM8/11/25
    to Sergey Grekhov, Alexander Thomas, Erik Ernst, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [co19] Roll co19 to 46c52754a2033f5127f01ea4e0df0e8a3f934cb6

    2025-08-07 sgrek...@gmail.com dart-lang/co19#3180. Add tests for JS interop type constructors (dart-lang/co19#3272)
    2025-08-07 sgrek...@gmail.com dart-lang/co19#3180. Add `isA` tests. Part 2. (dart-lang/co19#3271)
    2025-08-05 sgrek...@gmail.com dart-lang/co19#3180. Add `@JS()` annotation tests. Part 4. (dart-lang/co19#3270)
    2025-08-05 sgrek...@gmail.com dart-lang/co19#3180. Add `isA` tests. Part 1. (dart-lang/co19#3263)
    2025-08-01 sgrek...@gmail.com dart-lang/co19#3180. Add `@JS()` annotation tests. Part 1. (dart-lang/co19#3266)
    Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
    Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
    Commit-Queue: Alexander Thomas <at...@google.com>
    Reviewed-by: Erik Ernst <eer...@google.com>
    Reviewed-by: Alexander Thomas <at...@google.com>
    Files:
    • M DEPS
    • M tests/co19/co19-dart2js.status
    • M tests/co19/co19-dart2wasm.status
    • M tests/co19/co19-dartdevc.status
    Change size: S
    Delta: 4 files changed, 19 insertions(+), 6 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Erik Ernst, +1 by Alexander Thomas
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9825edca364520b072dc8da1277b7b0995f68626
    Gerrit-Change-Number: 444282
    Gerrit-PatchSet: 4
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages