[M] Change in dart/sdk[main]: [vm,dyn_modules] Support expression evaluation using bytecode
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Aug 8, 2025, 3:18:18 PM8/8/25
to Alexander Markov, Slava Egorov, Tess Strickland, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov and Tess Strickland
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slava Egorov
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
Aug 12, 2025, 6:59:11 AM8/12/25
to Alexander Markov, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Slava Egorov
Tess Strickland voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tess Strickland
| Code-Review | +1 |
2 comments
File runtime/vm/object.cc
Line 5231, Patchset 3 (Latest):
Zone* zone,Tess Strickland . unresolved
Nit: Considering its use below has a `thread` argument in scope, perhaps this should take the `thread` instead and avoid the `Thread::Current()` call in the bytecode case?
Line 5349, Patchset 3 (Latest):
auto zone = Thread::Current()->zone();Tess Strickland . unresolved
Nit: Is there a reason this is `Thread::Current()` instead of the `thread` argument?
Related details
Attention is currently required from:
- Alexander Markov
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Aug 12, 2025, 9:15:31 AM8/12/25
to Alexander Markov, Tess Strickland, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
Alexander Markov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
3 comments
Patchset-level comments
File runtime/vm/object.cc
Nit: Considering its use below has a `thread` argument in scope, perhaps this should take the `thread` instead and avoid the `Thread::Current()` call in the bytecode case?
Alexander Markov
Done
Nit: Is there a reason this is `Thread::Current()` instead of the `thread` argument?
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 12, 2025, 9:45:38 AM8/12/25
to Alexander Markov, Tess Strickland, Slava Egorov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: runtime/vm/object.cc
Insertions: 4, Deletions: 4.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[vm,dyn_modules] Support expression evaluation using bytecode
TEST=ci
Change-Id: Ice338112c190349d91791300954e70f192e04f2d
Cq-Include-Trybots: luci.dart.try:vm-aot-dyn-linux-debug-x64-try,vm-aot-dyn-linux-product-x64-try,vm-dyn-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444442
Reviewed-by: Tess Strickland <sstr...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M runtime/vm/bytecode_reader.cc
- M runtime/vm/bytecode_reader.h
- M runtime/vm/kernel_loader.cc
- M runtime/vm/kernel_loader.h
- M runtime/vm/object.cc
Change size: M
Delta: 5 files changed, 110 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tess Strickland
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages