[S] Change in dart/sdk[main]: [build] Use ad-hoc code signing by default.

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
Jun 1, 2026, 10:49:27 AM (2 days ago) Jun 1
to Slava Egorov, rev...@dartlang.org
Attention needed from Slava Egorov

Ryan Macnak added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ryan Macnak . unresolved

I had tests passing locally and failing on the bots because I forgot to pass --codesigning-identity=- in my local builds while working on https://dart-review.googlesource.com/c/sdk/+/505200.

Did you have a reason to not enable this by default when it was added in https://dart-review.googlesource.com/c/sdk/+/333401?

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I00b483581a04bfb4a4ed0d6212c767d67c003f83
Gerrit-Change-Number: 508164
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 14:49:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Jun 2, 2026, 5:00:10 AM (yesterday) Jun 2
to Ryan Macnak, rev...@dartlang.org
Attention needed from Ryan Macnak

Slava Egorov voted and added 1 comment

Votes added by Slava Egorov

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Ryan Macnak . resolved

I had tests passing locally and failing on the bots because I forgot to pass --codesigning-identity=- in my local builds while working on https://dart-review.googlesource.com/c/sdk/+/505200.

Did you have a reason to not enable this by default when it was added in https://dart-review.googlesource.com/c/sdk/+/333401?

Slava Egorov

I don't recall. Maybe I was concerned that something breaks in resigning / release flows? Lets try to enable it by default.

Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I00b483581a04bfb4a4ed0d6212c767d67c003f83
Gerrit-Change-Number: 508164
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 02 Jun 2026 09:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ryan Macnak <rma...@google.com>
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 2, 2026, 5:39:45 AM (yesterday) Jun 2
to Ryan Macnak, Slava Egorov, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[build] Use ad-hoc code signing by default.
Change-Id: I00b483581a04bfb4a4ed0d6212c767d67c003f83
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Slava Egorov <veg...@google.com>
Files:
  • M tools/bots/test_matrix.json
  • M tools/gn.py
Change size: S
Delta: 2 files changed, 1 insertion(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I00b483581a04bfb4a4ed0d6212c767d67c003f83
Gerrit-Change-Number: 508164
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
open
diffy
satisfied_requirement

Ryan Macnak (Gerrit)

unread,
12:48 PM (5 hours ago) 12:48 PM
to dart-...@luci-project-accounts.iam.gserviceaccount.com, Slava Egorov, rev...@dartlang.org

Ryan Macnak has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages