[L] Change in dart/sdk[main]: [vm/unsendable] Fix field handling in finding retaining path for unse...

0 views
Skip to first unread message

Slava Egorov (Gerrit)

unread,
Jan 9, 2026, 7:08:35 AM (2 days ago) Jan 9
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0fa7a931c4866cb43faee228f2d60f4e701e751a
Gerrit-Change-Number: 471621
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 12:08:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
Jan 9, 2026, 10:44:45 AM (2 days ago) Jan 9
to Alexander Aprelev, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Alexander Aprelev voted and added 1 comment

Votes added by Alexander Aprelev

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Aprelev . resolved

thank you Slava!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0fa7a931c4866cb43faee228f2d60f4e701e751a
Gerrit-Change-Number: 471621
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:44:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Jan 9, 2026, 10:44:55 AM (2 days ago) Jan 9
to Alexander Aprelev, Slava Egorov, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[vm/unsendable] Fix field handling in finding retaining path for unsendable values.

BUG=https://github.com/dart-lang/sdk/issues/62371
TEST=ci
Change-Id: I0fa7a931c4866cb43faee228f2d60f4e701e751a
Commit-Queue: Alexander Aprelev <a...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
  • M runtime/tests/vm/dart/isolates/send_unsupported_objects_test.dart
  • M runtime/vm/object_graph_copy.cc
Change size: L
Delta: 2 files changed, 124 insertions(+), 140 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0fa7a931c4866cb43faee228f2d60f4e701e751a
Gerrit-Change-Number: 471621
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages