[XS] Change in dart/sdk[main]: [co19] Roll co19 to 4d8035cc65081a3afa17029ea2af3dfd2c33aafe

0 views
Skip to first unread message

Sergey Grekhov (Gerrit)

unread,
Oct 31, 2025, 2:43:33 AM (3 days ago) Oct 31
to Alexander Thomas, Erik Ernst, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov has uploaded the change for review

Sergey Grekhov would like Alexander Thomas and Erik Ernst to review this change.

Commit message

[co19] Roll co19 to 4d8035cc65081a3afa17029ea2af3dfd2c33aafe

2025-10-30 sgrek...@gmail.com dart-lang/co19#3329. Add more private named parameters tests (dart-lang/co19#3375)
2025-10-30 sgrek...@gmail.com Update ffi package version (dart-lang/co19#3376)
2025-10-29 sgrek...@gmail.com dart-lang/co19#3329. Add tests for "corresponding public name" (dart-lang/co19#3361)
2025-10-29 sgrek...@gmail.com Fixes dart-lang/co19#3373. Fix constructor invocation in definition_t16.dart (dart-lang/co19#3374)
2025-10-29 sgrek...@gmail.com dart-lang/co19#3329. Add private named parameters tests. (dart-lang/co19#3362)
2025-10-29 sgrek...@gmail.com dart-lang/co19#2825. Add sanity rules tests (dart-lang/co19#3370)
2025-10-29 sgrek...@gmail.com Fixes dart-lang/co19#3371. Remove obsolete test Language/Classes/definition_t14.dart (dart-lang/co19#3372)

R=at...@google.com, eer...@google.com
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I20661baac57da24273c45abe48480c963c973895

Change information

Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20661baac57da24273c45abe48480c963c973895
Gerrit-Change-Number: 458760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Oct 31, 2025, 4:06:12 AM (3 days ago) Oct 31
to Sergey Grekhov, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20661baac57da24273c45abe48480c963c973895
Gerrit-Change-Number: 458760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 08:06:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sergey Grekhov (Gerrit)

unread,
Oct 31, 2025, 7:01:44 AM (3 days ago) Oct 31
to Commit Queue, Erik Ernst, Alexander Thomas, rev...@dartlang.org

Sergey Grekhov abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20661baac57da24273c45abe48480c963c973895
Gerrit-Change-Number: 458760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Oct 31, 2025, 7:02:25 AM (3 days ago) Oct 31
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org

Erik Ernst removed a vote from this change

Removed Code-Review+1 by Erik Ernst <eer...@google.com>
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteVote
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages