[L] Change in dart/sdk[main]: [cfe][PrimaryConstructor] Refactor handling of formals in body builder
0 views
Skip to first unread message
Johnni Winther (Gerrit)
Jan 9, 2026, 5:33:29 AM (2 days ago) Jan 9
to Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova
Johnni Winther added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Chloe Stefantsova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
Jan 9, 2026, 8:01:19 AM (2 days ago) Jan 9
to Johnni Winther, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Chloe Stefantsova voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Jan 9, 2026, 8:41:25 AM (2 days ago) Jan 9
to Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Johnni Winther voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 9, 2026, 8:51:40 AM (2 days ago) Jan 9
to Johnni Winther, Chloe Stefantsova, dart-fe-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cfe][PrimaryConstructor] Refactor handling of formals in body builder
Previously the formal parameters where passed both from the BodyBuilderContext and from the BodyBuilder.
Given that primary constructor body declaration cannot have direct access to the formal parameters on the primary constructor declaration, since there are not parsed together, the handling of formal parameters could not be done consistently with other function-like declarations.
This change normalizes the handling to only rely on the formals from BodyBuilderContext.
Change-Id: I910ecc95fc718da9ce71f406b28f0da2be442a62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/471440
Commit-Queue: Johnni Winther <johnni...@google.com>
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Files:
- M pkg/front_end/lib/src/builder/formal_parameter_builder.dart
- M pkg/front_end/lib/src/fragment/constructor/body_builder_context.dart
- M pkg/front_end/lib/src/fragment/constructor/declaration.dart
- M pkg/front_end/lib/src/fragment/constructor/encoding.dart
- M pkg/front_end/lib/src/fragment/factory/body_builder_context.dart
- M pkg/front_end/lib/src/fragment/factory/declaration.dart
- M pkg/front_end/lib/src/fragment/factory/encoding.dart
- M pkg/front_end/lib/src/fragment/getter/body_builder_context.dart
- M pkg/front_end/lib/src/fragment/getter/declaration.dart
- M pkg/front_end/lib/src/fragment/getter/encoding.dart
- M pkg/front_end/lib/src/fragment/method/body_builder_context.dart
- M pkg/front_end/lib/src/fragment/method/declaration.dart
- M pkg/front_end/lib/src/fragment/method/encoding.dart
- M pkg/front_end/lib/src/fragment/setter/body_builder_context.dart
- M pkg/front_end/lib/src/fragment/setter/declaration.dart
- M pkg/front_end/lib/src/fragment/setter/encoding.dart
- M pkg/front_end/lib/src/kernel/body_builder.dart
- M pkg/front_end/lib/src/kernel/body_builder_context.dart
- M pkg/front_end/lib/src/kernel/body_builder_helpers.dart
- M pkg/front_end/lib/src/kernel/resolver.dart
- M pkg/front_end/lib/src/kernel/utils.dart
- M pkg/front_end/lib/src/source/fragment_factory.dart
- M pkg/front_end/lib/src/source/fragment_factory_impl.dart
- M pkg/front_end/lib/src/source/outline_builder.dart
- M pkg/front_end/lib/src/source/source_enum_builder.dart
Change size: L
Delta: 25 files changed, 237 insertions(+), 424 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chloe Stefantsova
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages