[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Use internal/external helpers to create AST nodes

0 views
Skip to first unread message

Chloe Stefantsova (Gerrit)

unread,
Apr 24, 2026, 6:26:31 AMApr 24
to Johnni Winther, Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Gerrit-Change-Number: 497842
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 10:26:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chloe Stefantsova (Gerrit)

unread,
May 12, 2026, 8:07:57 AM (yesterday) May 12
to Johnni Winther, Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Gerrit-Change-Number: 497842
Gerrit-PatchSet: 4
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Tue, 12 May 2026 12:07:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
5:08 AM (4 hours ago) 5:08 AM
to Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova

Johnni Winther added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Johnni Winther . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Chloe Stefantsova
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Gerrit-Change-Number: 497842
Gerrit-PatchSet: 5
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Chloe Stefantsova (Gerrit)

unread,
5:09 AM (4 hours ago) 5:09 AM
to Johnni Winther, Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Gerrit-Change-Number: 497842
Gerrit-PatchSet: 5
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:09:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
5:11 AM (4 hours ago) 5:11 AM
to Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org

Johnni Winther voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Gerrit-Change-Number: 497842
Gerrit-PatchSet: 5
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:11:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
5:11 AM (4 hours ago) 5:11 AM
to Johnni Winther, Chloe Stefantsova, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[cfe][InternalNodes] Use internal/external helpers to create AST nodes

This replaces the creation of many AST nodes with calls to either the internal or external helpers, to help enforce passing of needed arguments, in particular file offset which are generally not required.
Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Commit-Queue: Johnni Winther <johnni...@google.com>
Files:
  • M pkg/front_end/lib/src/base/incremental_compiler.dart
  • M pkg/front_end/lib/src/base/lookup_result.dart
  • M pkg/front_end/lib/src/builder/formal_parameter_builder.dart
  • M pkg/front_end/lib/src/builder/metadata_builder.dart
  • M pkg/front_end/lib/src/fragment/constructor/encoding.dart
  • M pkg/front_end/lib/src/fragment/enum_element.dart
  • M pkg/front_end/lib/src/fragment/factory/encoding.dart
  • M pkg/front_end/lib/src/fragment/field/encoding.dart
  • M pkg/front_end/lib/src/fragment/fragment.dart
  • M pkg/front_end/lib/src/fragment/getter/encoding.dart
  • M pkg/front_end/lib/src/fragment/method/encoding.dart
  • M pkg/front_end/lib/src/fragment/setter/declaration.dart
  • M pkg/front_end/lib/src/fragment/setter/encoding.dart
  • M pkg/front_end/lib/src/kernel/body_builder.dart
  • M pkg/front_end/lib/src/kernel/body_builder_context.dart
  • M pkg/front_end/lib/src/kernel/body_builder_helpers.dart
  • M pkg/front_end/lib/src/kernel/collections.dart
  • M pkg/front_end/lib/src/kernel/combined_member_signature.dart
  • M pkg/front_end/lib/src/kernel/const_conditional_simplifier.dart
  • M pkg/front_end/lib/src/kernel/constant_evaluator.dart
  • M pkg/front_end/lib/src/kernel/constructor_tearoff_lowering.dart
  • M pkg/front_end/lib/src/kernel/expression_generator.dart
  • M pkg/front_end/lib/src/kernel/external_ast_helper.dart
  • M pkg/front_end/lib/src/kernel/forwarding_node.dart
  • M pkg/front_end/lib/src/kernel/internal_ast.dart
  • M pkg/front_end/lib/src/kernel/internal_ast_helper.dart
  • M pkg/front_end/lib/src/kernel/resolver.dart
  • M pkg/front_end/lib/src/kernel/resolver_helpers.dart
  • M pkg/front_end/lib/src/source/check_helper.dart
  • M pkg/front_end/lib/src/source/source_enum_builder.dart
  • M pkg/front_end/lib/src/type_inference/delayed_expressions.dart
  • M pkg/front_end/lib/src/type_inference/inference_visitor.dart
  • M pkg/front_end/lib/src/type_inference/matching_cache.dart
  • M pkg/front_end/lib/src/type_inference/type_inferrer.dart
  • M pkg/front_end/test/static_types/static_type_test.dart
  • M pkg/front_end/test/text_representation/internal_ast_text_representation_test.dart
  • M pkg/front_end/test/text_representation/text_representation_test.dart
  • M pkg/front_end/testcases/constructor_tearoffs/lowering/inferred_non_proper_rename.dart.strong.outline.expect
  • M pkg/front_end/testcases/offsets/case_variables_name_overlap.dart.strong.expect
  • M pkg/front_end/testcases/offsets/case_variables_name_overlap.dart.strong.modular.expect
  • M pkg/front_end/testcases/offsets/case_variables_name_overlap.dart.strong.transformed.expect
  • M pkg/front_end/testcases/offsets/ddc/case_variables_name_overlap.dart.strong.expect
  • M pkg/front_end/testcases/offsets/ddc/case_variables_name_overlap.dart.strong.modular.expect
  • M pkg/front_end/testcases/offsets/ddc/case_variables_name_overlap.dart.strong.transformed.expect
  • M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.expect
  • M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.modular.expect
  • M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.outline.expect
  • M pkg/front_end/testcases/offsets/ddc/external_field.dart.strong.transformed.expect
  • M pkg/front_end/testcases/offsets/external_field.dart.strong.expect
  • M pkg/front_end/testcases/offsets/external_field.dart.strong.modular.expect
  • M pkg/front_end/testcases/offsets/external_field.dart.strong.outline.expect
  • M pkg/front_end/testcases/offsets/external_field.dart.strong.transformed.expect
  • M pkg/front_end/testcases/offsets/pattern_for_loop.dart.strong.expect
  • M pkg/front_end/testcases/offsets/pattern_for_loop.dart.strong.modular.expect
  • M pkg/front_end/testcases/offsets/pattern_for_loop.dart.strong.transformed.expect
  • M pkg/front_end/testcases/offsets/switch_encoding.dart.strong.outline.expect
  • M pkg/kernel/lib/src/ast/expressions.dart
Change size: XL
Delta: 57 files changed, 2335 insertions(+), 1350 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Chloe Stefantsova
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9b2449f398492dd5fb8bf0c71fbe3ec04444c95
Gerrit-Change-Number: 497842
Gerrit-PatchSet: 6
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages