[L] Change in dart/sdk[main]: Update `package:meta` API and docs.

0 views

Skip to first unread message

Lasse Nielsen (Gerrit)

unread,

9:24 AM (11 hours ago) 9:24 AM

to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Samuel Rawlins

Lasse Nielsen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Lasse Nielsen . resolved

Was there to look at the `visibleForTesting` docs, decided to do something about the `private_names_in_public_api`.
(There is no good reason to expose those types. Let's see if the tests run, or if there are bad reasons to keep exposing them.)

Open in Gerrit

Related details

Attention is currently required from:

Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

10:34 AM (10 hours ago) 10:34 AM

to Lasse Nielsen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Lasse Nielsen

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Samuel Rawlins . resolved

Thanks Lasse! All of the comment changes look like a definite improvement to me.

Open in Gerrit

Related details

Attention is currently required from:

Lasse Nielsen

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages