Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[S] Change in dart/sdk[main]: Elements. Migrate ConstantFinder (tweaks).

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Mar 14, 2025, 10:44:30 AMMar 14
to Konstantin Shcheglov, Brian Wilkerson, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Phil Quitslund

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
  • Phil Quitslund
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I2dd82490fd5439f0dfaea6d2047969526197fb09
Gerrit-Change-Number: 415383
Gerrit-PatchSet: 3
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 14:44:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 14, 2025, 11:23:37 AMMar 14
to Brian Wilkerson, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Phil Quitslund

Konstantin Shcheglov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Phil Quitslund
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I2dd82490fd5439f0dfaea6d2047969526197fb09
Gerrit-Change-Number: 415383
Gerrit-PatchSet: 3
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 15:23:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 14, 2025, 11:23:52 AMMar 14
to Konstantin Shcheglov, Brian Wilkerson, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Elements. Migrate ConstantFinder (tweaks).
Change-Id: I2dd82490fd5439f0dfaea6d2047969526197fb09
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
  • M pkg/analyzer/lib/src/dart/constant/utilities.dart
  • M pkg/analyzer/lib/src/utilities/extensions/element.dart
Change size: S
Delta: 2 files changed, 20 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I2dd82490fd5439f0dfaea6d2047969526197fb09
Gerrit-Change-Number: 415383
Gerrit-PatchSet: 4
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages