[S] Change in dart/sdk[main]: [dds/dap] Send an Exited event when the debugged process exits

0 views
Skip to first unread message

Ben Konyi (Gerrit)

unread,
Oct 2, 2025, 10:47:53 AMOct 2
to Danny Tuppeny, Helin Shiah, rev...@dartlang.org
Attention needed from Danny Tuppeny and Helin Shiah

Ben Konyi voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
  • Helin Shiah
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
Gerrit-Change-Number: 453080
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Helin Shiah <hel...@google.com>
Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Helin Shiah <hel...@google.com>
Gerrit-Comment-Date: Thu, 02 Oct 2025 14:47:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Danny Tuppeny (Gerrit)

unread,
Oct 2, 2025, 11:42:23 AMOct 2
to Commit Queue, Helin Shiah, Ben Konyi, rev...@dartlang.org
Attention needed from Ben Konyi and Helin Shiah

Danny Tuppeny added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Danny Tuppeny . resolved

Fixed the bot, was just an unused import.

We need a bot that just notices these kinds of trivial issues and fixes them on the CL for us :-)

(or I do, at least!)

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Helin Shiah
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
Gerrit-Change-Number: 453080
Gerrit-PatchSet: 2
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Helin Shiah <hel...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Attention: Helin Shiah <hel...@google.com>
Gerrit-Comment-Date: Thu, 02 Oct 2025 15:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Helin Shiah (Gerrit)

unread,
Oct 2, 2025, 12:03:50 PMOct 2
to Danny Tuppeny, Commit Queue, Ben Konyi, rev...@dartlang.org
Attention needed from Ben Konyi and Danny Tuppeny

Helin Shiah voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Danny Tuppeny
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Gerrit-Change-Number: 453080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Helin Shiah <hel...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Attention: Ben Konyi <bko...@google.com>
    Gerrit-Comment-Date: Thu, 02 Oct 2025 16:03:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Helin Shiah (Gerrit)

    unread,
    Oct 2, 2025, 12:33:43 PMOct 2
    to Danny Tuppeny, Commit Queue, Ben Konyi, rev...@dartlang.org
    Attention needed from Ben Konyi and Danny Tuppeny

    Helin Shiah voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ben Konyi
    • Danny Tuppeny
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Gerrit-Change-Number: 453080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Helin Shiah <hel...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Attention: Ben Konyi <bko...@google.com>
    Gerrit-Comment-Date: Thu, 02 Oct 2025 16:33:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Danny Tuppeny (Gerrit)

    unread,
    Oct 13, 2025, 5:54:30 AMOct 13
    to Helin Shiah, Commit Queue, Ben Konyi, rev...@dartlang.org
    Attention needed from Ben Konyi and Helin Shiah

    Danny Tuppeny added 1 comment

    Patchset-level comments
    Danny Tuppeny . resolved

    @bko...@google.com friendly ping :)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ben Konyi
    • Helin Shiah
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Gerrit-Change-Number: 453080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Helin Shiah <hel...@google.com>
    Gerrit-Attention: Ben Konyi <bko...@google.com>
    Gerrit-Attention: Helin Shiah <hel...@google.com>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 09:54:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Ben Konyi (Gerrit)

    unread,
    Oct 30, 2025, 9:38:26 AM (6 days ago) Oct 30
    to Danny Tuppeny, Helin Shiah, Commit Queue, rev...@dartlang.org
    Attention needed from Danny Tuppeny and Helin Shiah

    Ben Konyi voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danny Tuppeny
    • Helin Shiah
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Gerrit-Change-Number: 453080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Helin Shiah <hel...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Attention: Helin Shiah <hel...@google.com>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 13:38:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ben Konyi (Gerrit)

    unread,
    Oct 30, 2025, 9:38:31 AM (6 days ago) Oct 30
    to Danny Tuppeny, Helin Shiah, Commit Queue, rev...@dartlang.org
    Attention needed from Danny Tuppeny and Helin Shiah

    Ben Konyi voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danny Tuppeny
    • Helin Shiah
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Gerrit-Change-Number: 453080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Helin Shiah <hel...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Attention: Helin Shiah <hel...@google.com>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 13:38:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Oct 30, 2025, 10:08:46 AM (6 days ago) Oct 30
    to Danny Tuppeny, Ben Konyi, Helin Shiah, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [dds/dap] Send an Exited event when the debugged process exits

    Fixes https://github.com/dart-lang/sdk/issues/51733
    Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Reviewed-by: Helin Shiah <hel...@google.com>
    Reviewed-by: Ben Konyi <bko...@google.com>
    Commit-Queue: Ben Konyi <bko...@google.com>
    Files:
    • M pkg/dds/lib/src/dap/adapters/dart.dart
    • M pkg/dds/lib/src/dap/adapters/dart_cli_adapter.dart
    • M pkg/dds/lib/src/dap/adapters/dart_test_adapter.dart
    • M pkg/dds/test/dap/integration/dart_test_test.dart
    • M pkg/dds/test/dap/integration/no_debug_test.dart
    • M pkg/dds/test/dap/integration/test_client.dart
    Change size: S
    Delta: 6 files changed, 48 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ben Konyi, +1 by Helin Shiah
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I26a619d9e1a36f6c3c188c2cdae8f1a61271e6fe
    Gerrit-Change-Number: 453080
    Gerrit-PatchSet: 3
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Helin Shiah <hel...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages