[L] Change in dart/sdk[main]: [vm/shared] Prohibit capturing of 'late final' variables by isolategr...
0 views
Skip to first unread message
Alexander Aprelev (Gerrit)
Dec 8, 2025, 1:56:47 PM12/8/25
to Alexander Aprelev, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
Alexander Aprelev voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Dec 8, 2025, 2:14:44 PM12/8/25
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
Slava Egorov added 1 comment![]( "Open in Gerrit")
File pkg/dart2bytecode/lib/local_vars.dart
Line 211, Patchset 1 (Latest):
bool get isFinalOrShared => (declaration.isFinal && !declaration.isLate) ||Slava Egorov . unresolved
I think current spec is effectively saying that:
- Global variables must be both final and shared.
- Local captured variables must be final (not required to be marked as shared though).
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Dec 8, 2025, 3:44:59 PM12/8/25
to Alexander Aprelev, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
Alexander Aprelev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Aprelev
| Commit-Queue | +1 |
1 comment
File pkg/dart2bytecode/lib/local_vars.dart
Line 211, Patchset 1:
bool get isFinalOrShared => (declaration.isFinal && !declaration.isLate) ||Slava Egorov . resolved
I think current spec is effectively saying that:
- Global variables must be both final and shared.
- Local captured variables must be final (not required to be marked as shared though).
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 8, 2025, 3:51:20 PM12/8/25
to Alexander Aprelev, Alexander Markov, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev and Slava Egorov
Alexander Markov added 2 comments![]( "Open in Gerrit")
File pkg/dart2bytecode/lib/declarations.dart
Line 1165, Patchset 2 (Latest):
static const capturesOnlyFinalNotLateVarsFlag = 1 << 3;Alexander Markov . unresolved
DBC
Please update `pkg/dart2bytecode/docs/bytecode.md` accordingly.
File pkg/dart2bytecode/lib/local_vars.dart
Line 200, Patchset 2 (Latest):
bool _isShared;Alexander Markov . unresolved
DBC
Is this still needed? If not, consider cleaning it up.
Related details
Attention is currently required from:
- Alexander Aprelev
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Dec 8, 2025, 4:22:12 PM12/8/25
to Alexander Aprelev, Alexander Markov, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Slava Egorov
Alexander Aprelev voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexander Aprelev
| Commit-Queue | +1 |
2 comments
File pkg/dart2bytecode/lib/declarations.dart
Line 1165, Patchset 2:
static const capturesOnlyFinalNotLateVarsFlag = 1 << 3;Alexander Markov . resolved
DBC
Please update `pkg/dart2bytecode/docs/bytecode.md` accordingly.
Alexander Aprelev
Done
File pkg/dart2bytecode/lib/local_vars.dart
DBC
Is this still needed? If not, consider cleaning it up.
Attention is currently required from:
- Alexander Markov
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Dec 9, 2025, 1:51:52 PM12/9/25
to Alexander Aprelev, Alexander Markov, Slava Egorov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Slava Egorov
Alexander Aprelev added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Slava Egorov (Gerrit)
Dec 10, 2025, 7:54:18 AM12/10/25
to Alexander Aprelev, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Dec 10, 2025, 10:52:24 AM12/10/25
to Alexander Aprelev, Slava Egorov, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Alexander Aprelev voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 10, 2025, 11:30:02 AM12/10/25
to Alexander Aprelev, Slava Egorov, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm/shared] Prohibit capturing of 'late final' variables by isolategroup-bound closures.
TEST=run_isolate_group_run_test
BUG=https://github.com/dart-lang/sdk/issues/62181
Change-Id: I50037ede337367020176262b98d2c2fd100b050a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/466820
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Files:
- M pkg/dart2bytecode/docs/bytecode.md
- M pkg/dart2bytecode/lib/bytecode_generator.dart
- M pkg/dart2bytecode/lib/declarations.dart
- M pkg/dart2bytecode/lib/local_vars.dart
- M runtime/vm/bytecode_reader.cc
- M runtime/vm/bytecode_reader.h
- M runtime/vm/ffi_callback_metadata.cc
- M runtime/vm/object.cc
- M runtime/vm/object.h
- M runtime/vm/scopes.cc
- M tests/ffi/isolate_group_bound_captured_local_test.dart
- M tests/ffi/run_isolate_group_run_test.dart
Change size: L
Delta: 12 files changed, 327 insertions(+), 210 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages