[L] Change in dart/sdk[main]: Clean up the prefer_initializing_formals lint.
Bob Nystrom (Gerrit)
Bob Nystrom voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- Brian Wilkerson
- Phil Quitslund
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Quitslund (Gerrit)
Phil Quitslund voted and added 2 comments![]( "Open in Gerrit")
Votes added by Phil Quitslund
| Code-Review | +1 |
2 comments
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS fileSad build is saying you need to sort this. (Search for the "Sort Members" command in the IDE.)
Related details
- Bob Nystrom
- Brian Wilkerson
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
// TODO(rnystrom): How can this ever be false?Good question. It probably can't be. The usual answer to a question like this is "invalid code", but I can't think of any way for invalid code to produce this situation. I would expect that if the name after `this` isn't defined in the current class that the analyzer would set the `field` to `null`.
If removing the test doesn't cause any tests to fail, then I think it's safe to assume that it isn't needed (though Konstantin might know of a path I'm not thinking of).
Related details
- Bob Nystrom
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Nystrom (Gerrit)
Bob Nystrom voted and added 2 comments![]( "Open in Gerrit")
Votes added by Bob Nystrom
| Auto-Submit | +1 |
2 comments
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS fileSad build is saying you need to sort this. (Search for the "Sort Members" command in the IDE.)
Done
// TODO(rnystrom): How can this ever be false?Good question. It probably can't be. The usual answer to a question like this is "invalid code", but I can't think of any way for invalid code to produce this situation. I would expect that if the name after `this` isn't defined in the current class that the analyzer would set the `field` to `null`.
If removing the test doesn't cause any tests to fail, then I think it's safe to assume that it isn't needed (though Konstantin might know of a path I'm not thinking of).
It turns out there is one test that fails if I comment this out. But it's only the test that the lint shouldn't fire if the assigned-to "field" is actually a setter. For that test, it's only the `field.isOriginDeclaration` part that matters. The other `enclosingElement` stuff doesn't seem to come into play.
I updated the comment and removed that unused half of the conditional.
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Nystrom (Gerrit)
Bob Nystrom voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |