[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. RST.

[Johnni Winther (Gerrit)]

Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther voted and added 1 comment

Votes added by Johnni Winther

Code-Review

+1

1 comment

File pkg/analyzer/test/src/diagnostics/set_element_from_deferred_library_test.dart

Line 22, Patchset 1 (Latest): test_const_ifElement_thenTrue_elseDeferred() async {

Johnni Winther . unresolved

Isn't this still failing? Should we expect `diag.setElementFromDeferredLibrary` instead `diag.nonConstantSetElement`?

Open in Gerrit

Related details

Attention is currently required from:

• Konstantin Shcheglov
• Paul Berry

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I5a8ad5b98e5a6c73b2ee4a0d51a9b51e875f47e8

Gerrit-Change-Number: 503280

Gerrit-PatchSet: 1

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Paul Berry <paul...@google.com>

Gerrit-CC: dart-...@luci-project-accounts.iam.gserviceaccount.com <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paul Berry <paul...@google.com>

Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>

Gerrit-Comment-Date: Wed, 13 May 2026 09:58:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes