[L] Change in dart/sdk[main]: [cfe] Merge Resolver.buildFieldInitializer1/2
0 views
Skip to first unread message
Chloe Stefantsova (Gerrit)
6:20 AM (3 hours ago) 6:20 AM
to Johnni Winther, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Chloe Stefantsova voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
6:30 AM (3 hours ago) 6:30 AM
to Alexander Thomas, Lasse Nielsen, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Alexander Thomas and Lasse Nielsen
Johnni Winther added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Johnni Winther . resolved
@athom for pkg/test_runner
@lrn for language tests
Related details
Attention is currently required from:
- Alexander Thomas
- Lasse Nielsen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Thomas (Gerrit)
6:35 AM (3 hours ago) 6:35 AM
to Johnni Winther, Lasse Nielsen, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Lasse Nielsen
Alexander Thomas voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Johnni Winther
- Lasse Nielsen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
6:48 AM (3 hours ago) 6:48 AM
to Johnni Winther, Alexander Thomas, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Lasse Nielsen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lasse Nielsen
| Code-Review | +1 |
1 comment
Patchset-level comments
Lasse Nielsen . resolved
Rubberstamp.
Seems the only visible change is to remove a "not a const" error from something that is also another error.
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
6:53 AM (3 hours ago) 6:53 AM
to Lasse Nielsen, Alexander Thomas, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Johnni Winther voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
6:53 AM (3 hours ago) 6:53 AM
to Johnni Winther, Lasse Nielsen, Alexander Thomas, Chloe Stefantsova, dart-fe-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cfe] Merge Resolver.buildFieldInitializer1/2
This update computation of implicit field types to return the inferred initializer. The ensure that we only compute the initializer once, and allows us to merge two pipelines for compute the field type and initializer.
Change-Id: I6005e19cc3dec9c717e426f06d817e2d45edcff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451480
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Reviewed-by: Alexander Thomas <at...@google.com>
Reviewed-by: Lasse Nielsen <l...@google.com>
Commit-Queue: Johnni Winther <johnni...@google.com>
Files:
- M pkg/front_end/lib/src/fragment/enum_element.dart
- M pkg/front_end/lib/src/fragment/field/body_builder_context.dart
- M pkg/front_end/lib/src/fragment/field/declaration.dart
- M pkg/front_end/lib/src/fragment/fragment.dart
- M pkg/front_end/lib/src/fragment/primary_constructor_field.dart
- M pkg/front_end/lib/src/kernel/body_builder.dart
- M pkg/front_end/lib/src/kernel/expression_generator.dart
- M pkg/front_end/lib/src/kernel/expression_generator_helper.dart
- M pkg/front_end/lib/src/kernel/implicit_field_type.dart
- M pkg/front_end/lib/src/kernel/resolver.dart
- M pkg/front_end/lib/src/type_inference/closure_context.dart
- M pkg/front_end/lib/src/type_inference/inference_visitor.dart
- M pkg/front_end/lib/src/type_inference/type_inferrer.dart
- M pkg/front_end/testcases/general/constants/issue_43431.dart.strong.outline.expect
- M pkg/front_end/testcases/general/constants/various.dart.strong.expect
- M pkg/front_end/testcases/general/constants/various.dart.strong.modular.expect
- M pkg/front_end/testcases/general/constants/various.dart.strong.outline.expect
- M pkg/front_end/testcases/general/constants/various.dart.strong.transformed.expect
- M pkg/test_runner/test/update_error_cmdline_test.dart
- M tests/language/compile_time_constant/compile_time_constant_test.dart
- M tests/language/final/initializer_instance_reference_test.dart
- M tests/language/method/not_found_test.dart
Change size: L
Delta: 22 files changed, 265 insertions(+), 268 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lasse Nielsen, +1 by Chloe Stefantsova, +1 by Alexander Thomas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages