[XS] Change in dart/sdk[main]: [gardening] Reduce test thread concurrency to make sure it passes und...

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Mar 13, 2026, 3:01:01 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev

Alexander Markov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibec809625719d5f7ab6525b6b0fa29df4c521b3d
Gerrit-Change-Number: 487887
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-CC: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 19:00:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
Mar 13, 2026, 3:15:50 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Alexander Aprelev voted and added 1 comment

Votes added by Alexander Aprelev

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Alexander Aprelev . resolved

thanks Alex!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibec809625719d5f7ab6525b6b0fa29df4c521b3d
Gerrit-Change-Number: 487887
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-CC: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 19:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 13, 2026, 3:16:08 PMMar 13
to Alexander Aprelev, Alexander Markov, Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[gardening] Reduce test thread concurrency to make sure it passes under tsan.

With new semispace max size set to 4, active mutators count is limited to 2(from standard 16), which puts significantly less stress on sanitizer infrastructure. Reducing isolates count from 20 to 4 still exercises isolate/thread management in the vm.

Fixes https://github.com/dart-lang/sdk/issues/62845
TEST=ci
Change-Id: Ibec809625719d5f7ab6525b6b0fa29df4c521b3d
Commit-Queue: Alexander Aprelev <a...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
  • M runtime/tests/vm/dart/isolates/many_isolates_blocked_at_process_run_sync_test.dart
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Markov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibec809625719d5f7ab6525b6b0fa29df4c521b3d
Gerrit-Change-Number: 487887
Gerrit-PatchSet: 6
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-CC: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages