[XS] Change in dart/sdk[main]: DeCo. Remove variants without representation type from tests/language...

0 views
Skip to first unread message

Kallen Tu (Gerrit)

unread,
Nov 24, 2025, 2:36:20 PMNov 24
to Konstantin Shcheglov, Erik Ernst, Paul Berry, Johnni Winther, Commit Queue, rev...@dartlang.org
Attention needed from Erik Ernst, Johnni Winther, Konstantin Shcheglov and Paul Berry

Kallen Tu added 1 comment

File tests/language/declaring_constructors/header/extension_type_test.dart
Line 16, Patchset 1 (Parent):extension type ET3(i);
Kallen Tu . unresolved

I think these both should be OK. I put these here based on a thread of comments with @eer...@google.com in https://dart-review.googlesource.com/c/sdk/+/457502/comment/a9fca80c_315a1633/

Open in Gerrit

Related details

Attention is currently required from:
  • Erik Ernst
  • Johnni Winther
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iacb4e85737463cbb4da834315d90692e2c6d42ef
Gerrit-Change-Number: 464122
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-CC: Erik Ernst <eer...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 24 Nov 2025 19:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Nov 25, 2025, 3:20:21 AMNov 25
to Konstantin Shcheglov, Paul Berry, Johnni Winther, Kallen Tu, Commit Queue, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry

Erik Ernst added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Erik Ernst . resolved

(Drive-by comment added).

File tests/language/declaring_constructors/header/extension_type_test.dart
Line 16, Patchset 1 (Parent):extension type ET3(i);
Kallen Tu . unresolved

I think these both should be OK. I put these here based on a thread of comments with @eer...@google.com in https://dart-review.googlesource.com/c/sdk/+/457502/comment/a9fca80c_315a1633/

Erik Ernst

Yes, the missing `final` is inferred when the declaration is an extension type.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iacb4e85737463cbb4da834315d90692e2c6d42ef
Gerrit-Change-Number: 464122
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-CC: Erik Ernst <eer...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Tue, 25 Nov 2025 08:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kallen Tu <kall...@google.com>
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Nov 26, 2025, 4:51:43 AMNov 26
to Konstantin Shcheglov, Erik Ernst, Paul Berry, Kallen Tu, Commit Queue, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther added 1 comment

File tests/language/declaring_constructors/header/extension_type_test.dart
Line 16, Patchset 1 (Parent):extension type ET3(i);
Kallen Tu . unresolved

I think these both should be OK. I put these here based on a thread of comments with @eer...@google.com in https://dart-review.googlesource.com/c/sdk/+/457502/comment/a9fca80c_315a1633/

Erik Ernst

Yes, the missing `final` is inferred when the declaration is an extension type.

Johnni Winther

Shouldn't `extension type ET3(i);` be an error since there is explicit type?

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iacb4e85737463cbb4da834315d90692e2c6d42ef
Gerrit-Change-Number: 464122
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-CC: Erik Ernst <eer...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Wed, 26 Nov 2025 09:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kallen Tu <kall...@google.com>
Comment-In-Reply-To: Erik Ernst <eer...@google.com>
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Nov 26, 2025, 5:15:26 AMNov 26
to Konstantin Shcheglov, Paul Berry, Johnni Winther, Kallen Tu, Commit Queue, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry

Erik Ernst added 2 comments

Patchset-level comments
Erik Ernst . resolved

(Another drive-by comment added)

File tests/language/declaring_constructors/header/extension_type_test.dart
Line 16, Patchset 1 (Parent):extension type ET3(i);
Kallen Tu . unresolved

I think these both should be OK. I put these here based on a thread of comments with @eer...@google.com in https://dart-review.googlesource.com/c/sdk/+/457502/comment/a9fca80c_315a1633/

Erik Ernst

Yes, the missing `final` is inferred when the declaration is an extension type.

Johnni Winther

Shouldn't `extension type ET3(i);` be an error since there is explicit type?

Erik Ernst

Again, using the general rules about formal parameter lists as part of the adoption of primary constructor syntax for extension types rather than special casing it, the type annotation can be omitted. So `ET3(i)` should be OK.

Gerrit-Comment-Date: Wed, 26 Nov 2025 10:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kallen Tu <kall...@google.com>
Comment-In-Reply-To: Erik Ernst <eer...@google.com>
Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
8:10 PM (2 hours ago) 8:10 PM
to Erik Ernst, Paul Berry, Johnni Winther, Kallen Tu, Commit Queue, rev...@dartlang.org

Konstantin Shcheglov abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages