[M] Change in dart/sdk[main]: [primary constructor]Add tests for property editor

0 views
Skip to first unread message

Keerti Parthasarathy (Gerrit)

unread,
Apr 20, 2026, 2:18:08 PM (2 days ago) Apr 20
to Brian Wilkerson, Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b7592cf7a11943fa74352ab95bdce5099cf8692
Gerrit-Change-Number: 496663
Gerrit-PatchSet: 1
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 18:18:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Apr 20, 2026, 2:29:48 PM (2 days ago) Apr 20
to Keerti Parthasarathy, Brian Wilkerson, Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b7592cf7a11943fa74352ab95bdce5099cf8692
Gerrit-Change-Number: 496663
Gerrit-PatchSet: 1
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 18:29:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Danny Tuppeny (Gerrit)

unread,
Apr 20, 2026, 3:10:43 PM (2 days ago) Apr 20
to Keerti Parthasarathy, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Danny Tuppeny added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Danny Tuppeny . resolved

lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b7592cf7a11943fa74352ab95bdce5099cf8692
Gerrit-Change-Number: 496663
Gerrit-PatchSet: 1
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 19:10:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
Apr 20, 2026, 5:05:23 PM (2 days ago) Apr 20
to Brian Wilkerson, Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Keerti Parthasarathy voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b7592cf7a11943fa74352ab95bdce5099cf8692
Gerrit-Change-Number: 496663
Gerrit-PatchSet: 1
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 21:05:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
Apr 21, 2026, 4:47:25 PM (19 hours ago) Apr 21
to Brian Wilkerson, Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Tue, 21 Apr 2026 20:47:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Apr 21, 2026, 5:20:10 PM (18 hours ago) Apr 21
to Keerti Parthasarathy, Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[primary constructor]Add tests for property editor
Change-Id: I4b7592cf7a11943fa74352ab95bdce5099cf8692
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Files:
  • M pkg/analysis_server/test/shared/shared_edit_argument_tests.dart
  • M pkg/analysis_server/test/shared/shared_editable_arguments_tests.dart
Change size: M
Delta: 2 files changed, 86 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b7592cf7a11943fa74352ab95bdce5099cf8692
Gerrit-Change-Number: 496663
Gerrit-PatchSet: 2
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages