[S] Change in dart/sdk[main]: [vm/service]: reuse deleted ID zone slots to bound array growth (#62205)
Nourhan Hasan (Gerrit)
Nourhan Hasan has uploaded the change for review![]( "Open in Gerrit")
Nourhan Hasan would like Liam Appelbe to review this change.
Commit message
[vm/service]: reuse deleted ID zone slots to bound array growth (#62205)
Adds a free list for indices, preventing unbounded
array growth on repeated create/delete cycles.
R=li...@google.com
Change information
- M runtime/vm/isolate.cc
- M runtime/vm/isolate.h
Related details
- Liam Appelbe
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nourhan Hasan (Gerrit)
Nourhan Hasan added 1 comment![]( "Open in Gerrit")
I created a second array (free_service_id_zone_slots_) that tracks which indices in service_id_zones_ are empty and available for reuse.
Related details
- Liam Appelbe
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liam Appelbe (Gerrit)
Liam Appelbe added 1 comment![]( "Open in Gerrit")
- Nourhan Hasan
- Ryan Macnak
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Ben Konyi added 1 comment![]( "Open in Gerrit")
const intptr_t zone_id = free_service_id_zone_slots_->Last();I don't think this is the right solution here, mainly because reusing IDs makes it easier for clients to accidentally delete ID zones using an old ID when the zone has already been reused.
The right solution would be to use a map of ID zone IDs -> ID zones instead of a growable array so that we can remove entries as zones are cleaned up.
Related details
- Nourhan Hasan
- Ryan Macnak
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nourhan Hasan (Gerrit)
Nourhan Hasan added 1 comment![]( "Open in Gerrit")
const intptr_t zone_id = free_service_id_zone_slots_->Last();I don't think this is the right solution here, mainly because reusing IDs makes it easier for clients to accidentally delete ID zones using an old ID when the zone has already been reused.
The right solution would be to use a map of ID zone IDs -> ID zones instead of a growable array so that we can remove entries as zones are cleaned up.
Thanks for the feedback. I hadn't considered this case. I chose the free list approach because it requires minimal changes and retains O(1) operations while keeping the array size bounded. However, I agree that using the map would be safer and more effective, but it would require more changes, I think, so I'll see how I can implement that.
Related details
- Ben Konyi
- Ryan Macnak
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nourhan Hasan (Gerrit)
Nourhan Hasan removed Liam Appelbe from this change![]( "Open in Gerrit")
- Liam Appelbe
Related details
- Ben Konyi
- Ryan Macnak
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |