[L] Change in dart/sdk[main]: analyzer: New warning for deprecated directive configurations
Samuel Rawlins (Gerrit)
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Sending to Brian to review the general idea of the new warning, and the name, so that Srujan can send `// ignore` lines to the Flutter Web SDK.
Related details
- Brian Wilkerson
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson voted and added 7 comments![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
7 comments
CorrectionApplicability.singleLocation;Is there a reason to not enable this for bulk fix?
deprecatedWebConfiguration:The name lgtm, and I agree that this should be a warning.
The analyzer produces this diagnostic when a deprecated library is used inShould we list the deprecated libraries that will be flagged?
If the library `p`:The code blocks with uri's don't display the file name / path automatically, so we put that information into the text. This usually starts with "Given a". In this case we'll need to include all of the file names. Perhaps something like
Given a package containing a file named `a.dart`:
...
a file named `a_io.dart`:
...
and a file named `a_web.dart`:
...
Otherwise readers won't see the file names.
The following code produces this diagnostic:Consider adding something like "because the configuration uses the dotted identifier `dart.library.html`"
var c = C();Consider adding a blank line before this line.
if (dart.library.html) 'src/hw_web.dart';Do we need to test any of the other deprecated libraries?
Related details
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |