Sergey Grekhov (Gerrit)

unread,

Jan 9, 2026, 5:39:18 AM (2 days ago) Jan 9

to Alexander Thomas, Erik Ernst, rev...@dartlang.org

Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov has uploaded the change for review

Sergey Grekhov would like Alexander Thomas and Erik Ernst to review this change.

Commit message

[co19] Roll co19 to 379503dac3a560fa1651d50d2920ab77f01e3d3a

2026-01-09 sgrek...@gmail.com Fixes dart-lang/co19#3499. Update expected errors positions for CFE (dart-lang/co19#3500)
2026-01-09 sgrek...@gmail.com dart-lang/co19#3182. Rename some `augmenting_types_*`. Part 2. (dart-lang/co19#3496)
2026-01-09 sgrek...@gmail.com dart-lang/co19#3182. Rename some `augmenting_types_*`. Part 3. (dart-lang/co19#3497)
2026-01-09 sgrek...@gmail.com dart-lang/co19#3182. Rename some `augmenting_types_*`. Part 4. (dart-lang/co19#3498)
2026-01-08 sgrek...@gmail.com dart-lang/co19#3182. Rename some `augmenting_types_*` tests to `applying_augmentations_*` (dart-lang/co19#3495)
2026-01-08 sgrek...@gmail.com dart-lang/co19#3182. Fix constructors augmentation in augmenting_constructors_A09_t02.dart (dart-lang/co19#3494)
2026-01-08 sgrek...@gmail.com dart-lang/co19#3182. Add type annotation inheritance tests (dart-lang/co19#3466)
2026-01-07 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for augmentations (dart-lang/co19#3465)
2026-01-07 sgrek...@gmail.com dart-lang/co19#3182. Remove obsolete `defining_augmentation_*` tests (dart-lang/co19#3461)
2026-01-07 sgrek...@gmail.com dart-lang/co19#3182. Fix enum syntax in `scoping_*` test (dart-lang/co19#3464)
2026-01-07 sgrek...@gmail.com dart-lang/co19#3182. Update `metadata_*.dart` tests (dart-lang/co19#3463)
2026-01-07 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_types_A10_*.dart tests (dart-lang/co19#3460)
2026-01-07 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for augmenting setters (dart-lang/co19#3445)
2026-01-06 sgrek...@gmail.com dart-lang/co19#3182. Remove obsolete `augmenting_types_A08_*` tests (dart-lang/co19#3459)
2026-01-06 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_types_A09_*.dart tests (dart-lang/co19#3458)
2026-01-06 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_types_A06_*.dart tests (dart-lang/co19#3456)
2026-01-06 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_types_A07_*.dart tests (dart-lang/co19#3457)
2026-01-06 sgrek...@gmail.com dart-lang/co19#3182. Remove obsolete `augmenting_members_*` tests (dart-lang/co19#3450)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3474. Remove tests that use obsolete in-body syntax (dart-lang/co19#3487)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3475. Fix constructor call in static_processing_A01_t02.dart (dart-lang/co19#3488)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3476. Fix a typo in static_processing_A01_t05.dart (dart-lang/co19#3489)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3480. Fix typos in static_processing_A02_t11.dart (dart-lang/co19#3493)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3477. Add missing `final` in static_processing_A01_t07.dart (dart-lang/co19#3490)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3478. Add missing representation field in static_processing_A02_t03.dart (dart-lang/co19#3491)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3479. Fix a typo in static_processing_A02_t04.dart (dart-lang/co19#3492)
2026-01-05 sgrek...@gmail.com dart-lang/co19#3182. Update assertions in augmenting_types_A01_*.dart (dart-lang/co19#3452)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3468. Don't instantiate abstract classes. (dart-lang/co19#3481)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3469. Fix call of an unnamed factory constructor. (dart-lang/co19#3482)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3470. Use correct syntax for const factory constructors (dart-lang/co19#3483)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3471. Fix the call to the unnamed factory constructor. (dart-lang/co19#3484)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3473. Update expected errors positions, fix typos (dart-lang/co19#3486)
2026-01-05 sgrek...@gmail.com Fixes dart-lang/co19#3472. Update expected errors positions (dart-lang/co19#3485)
2026-01-05 sgrek...@gmail.com dart-lang/co19#3182. Update assertions in augmenting_types_A02_*.dart (dart-lang/co19#3453)
2026-01-05 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_types_A05_*.dart tests (dart-lang/co19#3455)
2026-01-05 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_types_A03-4_*.dart tests (dart-lang/co19#3454)
2026-01-05 sgrek...@gmail.com dart-lang/co19#3182. Remove obsolete `augmenting_setters_*` tests (dart-lang/co19#3451)
2026-01-01 49699333+dependabot[bot]@users.noreply.github.com Bump the github-actions group with 2 updates (dart-lang/co19#3467)
2025-12-19 sgrek...@gmail.com dart-lang/co19#3182. Add test for late variables (dart-lang/co19#3449)
2025-12-19 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmenting functions and wildcards (dart-lang/co19#3432)

R=at...@google.com, eer...@google.com

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try

Change-Id: I62fc635e9d04ef91c28251cb942155420a8004c7

Change information

Files:

M DEPS

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

Alexander Thomas
Erik Ernst

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Erik Ernst (Gerrit)

unread,

Jan 9, 2026, 6:06:27 AM (2 days ago) Jan 9

to Sergey Grekhov, Alexander Thomas, Commit Queue, rev...@dartlang.org

Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Alexander Thomas
Sergey Grekhov

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sergey Grekhov (Gerrit)

unread,

Jan 9, 2026, 6:38:23 AM (2 days ago) Jan 9

to Erik Ernst, Alexander Thomas, Commit Queue, rev...@dartlang.org

Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov voted and added 1 comment

Votes added by Sergey Grekhov

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Sergey Grekhov . resolved

Can be landed. New failures are caused by an incomplete implementation of Augmentations.

Open in Gerrit

Related details

Attention is currently required from:

Alexander Thomas
Erik Ernst

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexander Thomas (Gerrit)

unread,

Jan 9, 2026, 6:55:42 AM (2 days ago) Jan 9

to Sergey Grekhov, Erik Ernst, Commit Queue, rev...@dartlang.org

Attention needed from Sergey Grekhov

Alexander Thomas voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Sergey Grekhov

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Commit Queue (Gerrit)

unread,

Jan 9, 2026, 7:05:15 AM (2 days ago) Jan 9

to Sergey Grekhov, Alexander Thomas, Erik Ernst, rev...@dartlang.org

Commit Queue submitted the change

Change information

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/471740

Reviewed-by: Erik Ernst <eer...@google.com>

Commit-Queue: Erik Ernst <eer...@google.com>

Auto-Submit: Sergey Grekhov <sgrek...@gmail.com>

Commit-Queue: Alexander Thomas <at...@google.com>

Reviewed-by: Alexander Thomas <at...@google.com>

Files:

M DEPS
M tests/co19/co19-dart2js.status
M tests/co19/co19-dart2wasm.status
M tests/co19/co19-dartdevc.status

Change size: S

Delta: 4 files changed, 34 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alexander Thomas, +1 by Erik Ernst

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 379503dac3a560fa1651d50d2920ab77f01e3d3a

Sergey Grekhov (Gerrit)

Sergey Grekhov has uploaded the change for review

Commit message

Change information

Related details

Erik Ernst (Gerrit)

Erik Ernst voted

Related details

Sergey Grekhov (Gerrit)

Sergey Grekhov voted and added 1 comment

Votes added by Sergey Grekhov

1 comment

Related details

Alexander Thomas (Gerrit)

Alexander Thomas voted

Related details

Commit Queue (Gerrit)

Commit Queue submitted the change

Change information