[M] Change in dart/sdk[main]: linter: use_late_for_private_fields_and_variables: count field formal...

0 views

Skip to first unread message

Brian Wilkerson (Gerrit)

unread,

Apr 21, 2026, 4:13:33 PM (19 hours ago) Apr 21

to Samuel Rawlins, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Apr 21, 2026, 5:41:46 PM (18 hours ago) Apr 21

to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Samuel Rawlins voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Apr 21, 2026, 5:42:05 PM (18 hours ago) Apr 21

to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

linter: use_late_for_private_fields_and_variables: count field formals as nullable assignments

Fixes https://github.com/dart-lang/sdk/issues/63212

I added many test cases that are related and were missing, but the
primary test case for the bug is
`test_instanceField_private_withFieldFormalParameter`.

Change-Id: I3e8951f63801333373459bb1b191579b8e1f2188

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/497101

Reviewed-by: Brian Wilkerson <brianwi...@google.com>

Commit-Queue: Samuel Rawlins <sraw...@google.com>

Files:

M pkg/linter/lib/src/rules/use_late_for_private_fields_and_variables.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart

Change size: M

Delta: 2 files changed, 60 insertions(+), 5 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Brian Wilkerson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages