[M] Change in dart/sdk[main]: AD. Collect LibraryCycle(s) to load iteratively.

[Morgan :) (Gerrit)]

Attention needed from Johnni Winther and Konstantin Shcheglov

Morgan :) added 1 comment

File pkg/analyzer/lib/src/dart/analysis/library_context.dart

Line 194, Patchset 2 (Latest): List<LibraryCycle> _collectCyclesToLoad(LibraryCycle root) {

Morgan :) . unresolved

There is a specific algorithm for doing this called Tarjan's algorithm, it's implemented in package:graph here

https://github.com/dart-lang/tools/blob/main/pkgs/graphs/lib/src/strongly_connected_components.dart

I never took the time to fully understand how it works and why it's faster, but I have been very happy with its performance in build_runner :)

Open in Gerrit

Related details

Attention is currently required from:

• Johnni Winther
• Konstantin Shcheglov

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I2379c33f79f55157506c3fa0f7672df98064b46b

Gerrit-Change-Number: 487720

Gerrit-PatchSet: 2

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Morgan :) <david...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 07:49:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Johnni Winther (Gerrit)]

Attention needed from Konstantin Shcheglov

Johnni Winther voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Konstantin Shcheglov

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I2379c33f79f55157506c3fa0f7672df98064b46b

Gerrit-Change-Number: 487720

Gerrit-PatchSet: 2

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Morgan :) <david...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 10:17:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Konstantin Shcheglov (Gerrit)]

Attention needed from Morgan :)

Konstantin Shcheglov voted and added 1 comment

Votes added by Konstantin Shcheglov

Commit-Queue

+2

1 comment

File pkg/analyzer/lib/src/dart/analysis/library_context.dart

Line 194, Patchset 2 (Latest): List<LibraryCycle> _collectCyclesToLoad(LibraryCycle root) {

Morgan :) . unresolved

There is a specific algorithm for doing this called Tarjan's algorithm, it's implemented in package:graph here

https://github.com/dart-lang/tools/blob/main/pkgs/graphs/lib/src/strongly_connected_components.dart

I never took the time to fully understand how it works and why it's faster, but I have been very happy with its performance in build_runner :)

Konstantin Shcheglov

Yes, we already used this algorithm while building LibraryCycle(s) in `library_graph.dart`. The code here is just a simple iterative post-order traversal over already built DAG of cycles.

Open in Gerrit

Related details

Attention is currently required from:

• Morgan :)

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I2379c33f79f55157506c3fa0f7672df98064b46b

Gerrit-Change-Number: 487720

Gerrit-PatchSet: 2

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Morgan :) <david...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Morgan :) <david...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 15:39:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Morgan :) <david...@google.com>

[Commit Queue (Gerrit)]

Commit Queue submitted the change

Change information

Commit message:

AD. Collect LibraryCycle(s) to load iteratively.

Instead of loading them recursively.
This caused stack overflows in case of long (5000, 4000, 3000) chains
of importing libraries.

Change-Id: I2379c33f79f55157506c3fa0f7672df98064b46b

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487720

Reviewed-by: Johnni Winther <johnni...@google.com>

Commit-Queue: Konstantin Shcheglov <sche...@google.com>

Files:

• M pkg/analyzer/lib/src/dart/analysis/library_context.dart
• M pkg/analyzer/lib/src/dart/analysis/library_graph.dart

Change size: M

Delta: 2 files changed, 51 insertions(+), 11 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Johnni Winther

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I2379c33f79f55157506c3fa0f7672df98064b46b

Gerrit-Change-Number: 487720

Gerrit-PatchSet: 3

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

[Morgan :) (Gerrit)]

Morgan :) added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Morgan :) . resolved

Ah good, LGTM then :) thanks!

File pkg/analyzer/lib/src/dart/analysis/library_context.dart

Line 194, Patchset 2: List<LibraryCycle> _collectCyclesToLoad(LibraryCycle root) {

Morgan :) . resolved

There is a specific algorithm for doing this called Tarjan's algorithm, it's implemented in package:graph here

https://github.com/dart-lang/tools/blob/main/pkgs/graphs/lib/src/strongly_connected_components.dart

I never took the time to fully understand how it works and why it's faster, but I have been very happy with its performance in build_runner :)

Konstantin Shcheglov

Yes, we already used this algorithm while building LibraryCycle(s) in `library_graph.dart`. The code here is just a simple iterative post-order traversal over already built DAG of cycles.

Morgan :)

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I2379c33f79f55157506c3fa0f7672df98064b46b

Gerrit-Change-Number: 487720

Gerrit-PatchSet: 3

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Morgan :) <david...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 16:03:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Morgan :) <david...@google.com>

Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>