[L] Change in dart/sdk[main]: [analysis_server] Add Dart-Code's current client capabilities

[Danny Tuppeny (Gerrit)]

Attention needed from Brian Wilkerson

Danny Tuppeny added 1 comment

File pkg/analysis_server/doc/lsp/client_capabilities/README.md

Line 1, Patchset 1 (Latest):# LSP Client Capabilities

Danny Tuppeny . unresolved

Is `doc/` an appropriate place to store these? I also considered `lib/src/lsp` and `tool/`, but none of them feel quite right.

There's also `package:language_server_protocol` but this doesn't feel so much like "protocol".

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I11e6fa0a6893e7ee6073d76644053419b80384d2

Gerrit-Change-Number: 524601

Gerrit-PatchSet: 1

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Comment-Date: Wed, 15 Jul 2026 18:51:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Brian Wilkerson (Gerrit)]

Attention needed from Danny Tuppeny and Keerti Parthasarathy

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review	+1
Commit-Queue	+1

1 comment

File pkg/analysis_server/doc/lsp/client_capabilities/README.md

Line 1, Patchset 1 (Latest):# LSP Client Capabilities

Danny Tuppeny . unresolved

Is `doc/` an appropriate place to store these? I also considered `lib/src/lsp` and `tool/`, but none of them feel quite right.

There's also `package:language_server_protocol` but this doesn't feel so much like "protocol".

Brian Wilkerson

I agree that none of the places feels quite right, but this feels like the least bad to me. I tried to think of an alternative, but I didn't come up with anything I really liked.

Open in Gerrit

Related details

Attention is currently required from:

• Danny Tuppeny
• Keerti Parthasarathy

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I11e6fa0a6893e7ee6073d76644053419b80384d2

Gerrit-Change-Number: 524601

Gerrit-PatchSet: 1

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>

Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>

Gerrit-Comment-Date: Wed, 15 Jul 2026 19:15:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Danny Tuppeny <da...@tuppeny.com>