[S] Change in dart/sdk[main]: [linter] Add diagnostic doc for eol_at_end_of_file lint

2 views
Skip to first unread message

Parker Lougheed (Gerrit)

unread,
Jul 24, 2026, 7:17:01 PMJul 24
to dart-analys...@google.com, rev...@dartlang.org

Parker Lougheed has uploaded the change for review

Commit message

[linter] Add diagnostic doc for eol_at_end_of_file lint

Due to how Markdown code blocks are rendered, there's not a great way to showcase the difference in extra new lines. So I went with inline comments indicating where the files end. Let me know if you think a different direction might work better. Thanks!
Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae

Change information

Files:
  • M pkg/analyzer/test/verify_diagnostics_test.dart
  • M pkg/linter/messages.yaml
Change size: S
Delta: 2 files changed, 46 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
Gerrit-Change-Number: 527840
Gerrit-PatchSet: 1
Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jul 25, 2026, 11:52:34 AMJul 25
to Parker Lougheed, Connie Ooi, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Connie Ooi and Parker Lougheed

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review+1

1 comment

File pkg/analyzer/test/verify_diagnostics_test.dart
Line 200, Patchset 1 (Latest): // and the reported range is past the end of the content.
Brian Wilkerson . resolved

I'm guessing that this is the important part.

If the only problem is the extra diagnostic in some cases, then we could use an `%ignore` directive to ignore that diagnostic. But the requirement to have a highlight range seems to be impossible to satisfy. (At least, without changing the lint. I suppose we could have it report on the (non-comment) token before the end-of-file token, and then there'd be text to highlight.)

Open in Gerrit

Related details

Attention is currently required from:
  • Connie Ooi
  • Parker Lougheed
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
    Gerrit-Change-Number: 527840
    Gerrit-PatchSet: 1
    Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Connie Ooi <conn...@google.com>
    Gerrit-Attention: Connie Ooi <conn...@google.com>
    Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
    Gerrit-Comment-Date: Sat, 25 Jul 2026 15:52:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    Aug 19, 2026, 1:58:52 PMAug 19
    to Parker Lougheed, Connie Ooi, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Connie Ooi and Parker Lougheed

    Brian Wilkerson added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Brian Wilkerson . resolved

    This CL review appears to have been dropped.

    Connie: can you take a look at the docs? I'm ok with the changes to the test if we're ready to land the text.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Connie Ooi
    • Parker Lougheed
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
    Gerrit-Change-Number: 527840
    Gerrit-PatchSet: 1
    Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Connie Ooi <conn...@google.com>
    Gerrit-Attention: Connie Ooi <conn...@google.com>
    Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
    Gerrit-Comment-Date: Wed, 19 Aug 2026 17:58:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Connie Ooi (Gerrit)

    unread,
    Aug 20, 2026, 5:19:16 PMAug 20
    to Parker Lougheed, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Parker Lougheed

    Connie Ooi added 1 comment

    Patchset-level comments
    Brian Wilkerson . resolved

    This CL review appears to have been dropped.

    Connie: can you take a look at the docs? I'm ok with the changes to the test if we're ready to land the text.

    Connie Ooi

    Yes, will get to it today!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Parker Lougheed
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
    Gerrit-Change-Number: 527840
    Gerrit-PatchSet: 1
    Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Connie Ooi <conn...@google.com>
    Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
    Gerrit-Comment-Date: Thu, 20 Aug 2026 21:19:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Connie Ooi (Gerrit)

    unread,
    Aug 20, 2026, 6:23:13 PMAug 20
    to Parker Lougheed, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Parker Lougheed

    Connie Ooi added 3 comments

    File pkg/linter/messages.yaml
    Line 5487, Patchset 1 (Latest): The analyzer produces this diagnostic when a non-empty Dart file
    doesn't end with exactly one newline.
    The file either doesn't end with a newline,
    or it ends with more than one.
    Connie Ooi . unresolved

    The analyzer produces this diagnostic when a non-empty Dart file
    doesn't end with a single newline.
    This occurs when a file has no trailing newline,
    or when it has multiple trailing newlines.

    Line 5492, Patchset 1 (Latest): Because trailing newlines aren't visible in a code block,
    the examples below use a comment to mark where the file ends.
    Connie Ooi . unresolved

    Trailing newlines aren't visible in rendered code blocks.
    To make them clear, the examples below use comments to show
    where each file ends.

    Line 5504, Patchset 1 (Latest): The following code produces this diagnostic because
    the file ends with more than one newline:
    Connie Ooi . unresolved

    The following code produces this diagnostic
    because the file ends with multiple newlines:

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Parker Lougheed
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
    Gerrit-Change-Number: 527840
    Gerrit-PatchSet: 1
    Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Connie Ooi <conn...@google.com>
    Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
    Gerrit-Comment-Date: Thu, 20 Aug 2026 22:23:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Parker Lougheed (Gerrit)

    unread,
    Aug 28, 2026, 10:24:48 AMAug 28
    to Connie Ooi, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Connie Ooi

    Parker Lougheed added 4 comments

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Parker Lougheed . resolved

    Thanks for the suggestions! Applied :)

    File pkg/linter/messages.yaml
    Line 5487, Patchset 1: The analyzer produces this diagnostic when a non-empty Dart file

    doesn't end with exactly one newline.
    The file either doesn't end with a newline,
    or it ends with more than one.
    Connie Ooi . resolved

    The analyzer produces this diagnostic when a non-empty Dart file
    doesn't end with a single newline.
    This occurs when a file has no trailing newline,
    or when it has multiple trailing newlines.

    Parker Lougheed

    Done

    Line 5492, Patchset 1: Because trailing newlines aren't visible in a code block,

    the examples below use a comment to mark where the file ends.
    Connie Ooi . resolved

    Trailing newlines aren't visible in rendered code blocks.
    To make them clear, the examples below use comments to show
    where each file ends.

    Parker Lougheed

    Done

    Line 5504, Patchset 1: The following code produces this diagnostic because

    the file ends with more than one newline:
    Connie Ooi . resolved

    The following code produces this diagnostic
    because the file ends with multiple newlines:

    Parker Lougheed

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Connie Ooi
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
      Gerrit-Change-Number: 527840
      Gerrit-PatchSet: 2
      Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
      Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Reviewer: Connie Ooi <conn...@google.com>
      Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Attention: Connie Ooi <conn...@google.com>
      Gerrit-Comment-Date: Fri, 28 Aug 2026 14:24:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Connie Ooi <conn...@google.com>
      unsatisfied_requirement
      open
      diffy

      Brian Wilkerson (Gerrit)

      unread,
      Aug 28, 2026, 10:45:15 AMAug 28
      to Parker Lougheed, Brian Wilkerson, Connie Ooi, dart-analys...@google.com, rev...@dartlang.org
      Attention needed from Connie Ooi and Parker Lougheed

      Brian Wilkerson voted

      Code-Review+1
      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Connie Ooi
      • Parker Lougheed
      Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
        Gerrit-Change-Number: 527840
        Gerrit-PatchSet: 2
        Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Connie Ooi <conn...@google.com>
        Gerrit-Attention: Connie Ooi <conn...@google.com>
        Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
        Gerrit-Comment-Date: Fri, 28 Aug 2026 14:45:11 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Parker Lougheed (Gerrit)

        unread,
        Sep 4, 2026, 5:08:57 AMSep 4
        to Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, Connie Ooi, dart-analys...@google.com, rev...@dartlang.org
        Attention needed from Connie Ooi and Paul Berry

        Parker Lougheed added 1 comment

        Patchset-level comments
        File-level comment, Patchset 3 (Latest):
        Parker Lougheed . resolved

        Looks like I need another reviewer for the test update. Mind taking a look? Thanks!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Connie Ooi
        • Paul Berry
        Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
        Gerrit-Change-Number: 527840
        Gerrit-PatchSet: 3
        Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Connie Ooi <conn...@google.com>
        Gerrit-Reviewer: Paul Berry <paul...@google.com>
        Gerrit-Attention: Paul Berry <paul...@google.com>
        Gerrit-Attention: Connie Ooi <conn...@google.com>
        Gerrit-Comment-Date: Fri, 04 Sep 2026 09:08:53 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Brian Wilkerson (Gerrit)

        unread,
        Sep 4, 2026, 9:54:49 AMSep 4
        to Parker Lougheed, Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, Connie Ooi, dart-analys...@google.com, rev...@dartlang.org
        Attention needed from Connie Ooi, Konstantin Shcheglov, Parker Lougheed and Paul Berry

        Brian Wilkerson voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Connie Ooi
        • Konstantin Shcheglov
        • Parker Lougheed
        • Paul Berry
        Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
        Gerrit-Change-Number: 527840
        Gerrit-PatchSet: 3
        Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Connie Ooi <conn...@google.com>
        Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Paul Berry <paul...@google.com>
        Gerrit-Attention: Paul Berry <paul...@google.com>
        Gerrit-Attention: Connie Ooi <conn...@google.com>
        Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
        Gerrit-Comment-Date: Fri, 04 Sep 2026 13:54:44 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Connie Ooi (Gerrit)

        unread,
        Sep 4, 2026, 1:21:21 PMSep 4
        to Parker Lougheed, Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
        Attention needed from Konstantin Shcheglov, Parker Lougheed and Paul Berry

        Connie Ooi voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Konstantin Shcheglov
        • Parker Lougheed
        • Paul Berry
        Submit Requirements:
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: sdk
          Gerrit-Branch: main
          Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
          Gerrit-Change-Number: 527840
          Gerrit-PatchSet: 3
          Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
          Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Reviewer: Connie Ooi <conn...@google.com>
          Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Reviewer: Paul Berry <paul...@google.com>
          Gerrit-Attention: Paul Berry <paul...@google.com>
          Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
          Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Comment-Date: Fri, 04 Sep 2026 17:21:17 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Brian Wilkerson (Gerrit)

          unread,
          Sep 4, 2026, 1:29:27 PMSep 4
          to Parker Lougheed, Brian Wilkerson, Connie Ooi, Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
          Attention needed from Konstantin Shcheglov, Parker Lougheed and Paul Berry

          Brian Wilkerson voted Commit-Queue+2

          Commit-Queue+2
          Gerrit-Comment-Date: Fri, 04 Sep 2026 17:29:24 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Konstantin Shcheglov (Gerrit)

          unread,
          Sep 4, 2026, 2:35:04 PMSep 4
          to Parker Lougheed, Brian Wilkerson, Connie Ooi, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
          Attention needed from Brian Wilkerson, Parker Lougheed and Paul Berry

          Konstantin Shcheglov voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Brian Wilkerson
          • Parker Lougheed
          • Paul Berry
          Submit Requirements:
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: sdk
          Gerrit-Branch: main
          Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
          Gerrit-Change-Number: 527840
          Gerrit-PatchSet: 3
          Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
          Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Reviewer: Connie Ooi <conn...@google.com>
          Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Reviewer: Paul Berry <paul...@google.com>
          Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Attention: Paul Berry <paul...@google.com>
          Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
          Gerrit-Comment-Date: Fri, 04 Sep 2026 18:35:00 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Brian Wilkerson (Gerrit)

          unread,
          Sep 4, 2026, 2:53:58 PMSep 4
          to Parker Lougheed, Konstantin Shcheglov, Brian Wilkerson, Connie Ooi, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
          Attention needed from Parker Lougheed and Paul Berry

          Brian Wilkerson voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Parker Lougheed
          • Paul Berry
          Submit Requirements:
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: sdk
          Gerrit-Branch: main
          Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
          Gerrit-Change-Number: 527840
          Gerrit-PatchSet: 3
          Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
          Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Reviewer: Connie Ooi <conn...@google.com>
          Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Reviewer: Paul Berry <paul...@google.com>
          Gerrit-Attention: Paul Berry <paul...@google.com>
          Gerrit-Attention: Parker Lougheed <parl...@gmail.com>
          Gerrit-Comment-Date: Fri, 04 Sep 2026 18:53:54 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

          unread,
          Sep 4, 2026, 3:19:09 PMSep 4
          to Parker Lougheed, Konstantin Shcheglov, Brian Wilkerson, Connie Ooi, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

          dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

          Change information

          Commit message:
          [linter] Add diagnostic doc for eol_at_end_of_file lint

          Due to how Markdown code blocks are rendered, there's not a great way to showcase the difference in extra new lines. So I went with inline comments indicating where the files end. Let me know if you think a different direction might work better. Thanks!
          Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
          Reviewed-by: Konstantin Shcheglov <sche...@google.com>
          Reviewed-by: Connie Ooi <conn...@google.com>
          Reviewed-by: Brian Wilkerson <brianwi...@google.com>
          Commit-Queue: Brian Wilkerson <brianwi...@google.com>
          Files:
          • M pkg/analyzer/test/verify_diagnostics_test.dart
          • M pkg/linter/messages.yaml
          Change size: S
          Delta: 2 files changed, 47 insertions(+), 0 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Brian Wilkerson, +1 by Connie Ooi
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: sdk
          Gerrit-Branch: main
          Gerrit-Change-Id: Iba68215aaf4f9d1e7a99c06a46801afb9f4df3ae
          Gerrit-Change-Number: 527840
          Gerrit-PatchSet: 4
          Gerrit-Owner: Parker Lougheed <parl...@gmail.com>
          Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
          Gerrit-Reviewer: Connie Ooi <conn...@google.com>
          Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
          Gerrit-Reviewer: Paul Berry <paul...@google.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages