[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

[Brian Wilkerson (Gerrit)]

Attention needed from Paul Berry and Samuel Rawlins

Brian Wilkerson added 1 comment

File pkg/analyzer/lib/src/error/annotation_verifier.dart

Line 412, Patchset 3 (Latest): if (parent.parent?.parent is ExtensionTypeDeclaration ||

Brian Wilkerson . unresolved

Why is this case considered to be an overridable-member? (That is, why isn't the target enough to catch this case?)

Open in Gerrit

Related details

Attention is currently required from:

• Paul Berry
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ibcde2f99cf53460bff636bfc8bbf07e80779a942

Gerrit-Change-Number: 469104

Gerrit-PatchSet: 3

Gerrit-Owner: Samuel Rawlins <sraw...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Paul Berry <paul...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paul Berry <paul...@google.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Fri, 19 Dec 2025 17:48:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Samuel Rawlins (Gerrit)]

Attention needed from Brian Wilkerson and Paul Berry

Samuel Rawlins added 1 comment

File pkg/analyzer/lib/src/error/annotation_verifier.dart

Line 412, Patchset 3 (Latest): if (parent.parent?.parent is ExtensionTypeDeclaration ||

Brian Wilkerson . unresolved

Why is this case considered to be an overridable-member? (That is, why isn't the target enough to catch this case?)

Samuel Rawlins

I'm not sure. It's not documented. I could leave a TODO to look into the existing behavior.

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Paul Berry

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ibcde2f99cf53460bff636bfc8bbf07e80779a942

Gerrit-Change-Number: 469104

Gerrit-PatchSet: 3

Gerrit-Owner: Samuel Rawlins <sraw...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Paul Berry <paul...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Paul Berry <paul...@google.com>

Gerrit-Comment-Date: Fri, 19 Dec 2025 19:27:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>

[Brian Wilkerson (Gerrit)]

Attention needed from Paul Berry and Samuel Rawlins

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review

+1

1 comment

File pkg/analyzer/lib/src/error/annotation_verifier.dart

Line 412, Patchset 3 (Latest): if (parent.parent?.parent is ExtensionTypeDeclaration ||

Brian Wilkerson . resolved

Why is this case considered to be an overridable-member? (That is, why isn't the target enough to catch this case?)

Samuel Rawlins

I'm not sure. It's not documented. I could leave a TODO to look into the existing behavior.

Brian Wilkerson

I don't care whether you add a TODO, but I think it's probably worth following up on at some point. Seems like we shouldn't need to special case anything here.

Open in Gerrit

Related details

Attention is currently required from:

• Paul Berry
• Samuel Rawlins

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ibcde2f99cf53460bff636bfc8bbf07e80779a942

Gerrit-Change-Number: 469104

Gerrit-PatchSet: 3

Gerrit-Owner: Samuel Rawlins <sraw...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Paul Berry <paul...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paul Berry <paul...@google.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Fri, 19 Dec 2025 19:30:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>

Comment-In-Reply-To: Samuel Rawlins <sraw...@google.com>

[Paul Berry (Gerrit)]

Attention needed from Samuel Rawlins

Paul Berry voted and added 1 comment

Votes added by Paul Berry

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Paul Berry . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Samuel Rawlins

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ibcde2f99cf53460bff636bfc8bbf07e80779a942

Gerrit-Change-Number: 469104

Gerrit-PatchSet: 3

Gerrit-Owner: Samuel Rawlins <sraw...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Paul Berry <paul...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Sat, 20 Dec 2025 19:02:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes