[M] Change in dart/sdk[main]: [vm] Improvements for --trace-debugger-stacktrace output.
0 views
Skip to first unread message
Tess Strickland (Gerrit)
Dec 10, 2025, 7:01:08 AM12/10/25
to Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
Dec 10, 2025, 7:45:26 AM12/10/25
to Commit Queue, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tess Strickland
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Tess Strickland . resolved
Okay, done tweaking the traces by adding a verbose mode as well so that non-collected info is only output when verbose tracing is requested.
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 10, 2025, 11:50:16 AM12/10/25
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov voted![]( "Open in Gerrit")
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 10, 2025, 11:50:34 AM12/10/25
to Tess Strickland, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Improvements for --trace-debugger-stacktrace output.
Improves the readability of the tracing output by adding beginning and
ending markers for debugger stacktrace collection and using specific
spacing instead of \t in output, so that output is more naturally nested
via indention:
* beginning/ending markers are not indented,
* frames are indented by two spaces, and
* additional output while collecting a frame is indented by four spaces.
Adds tracing for DebuggerStackTrace::CollectAsyncAwaiters(). A different
ending marker is used in the case when the collected trace is discarded
due to a lack of async awaiters.
ActivationFrame::GetSavedCurrentContext now takes an optional out
parameter for the current context variable index, which is only used by
CollectDartFrame and used to print the index there. This eliminates
extra output when this method is used outside collecting stack traces.
When the current context variable index is requested,
GetSavedCurrentContext ignores the cached context if any so that the
index is appropriately set if an appropriate variable is found.
By default, skips tracing of non-collected frames and repeated async
suspensions in async awaiter traces. Use the new
--trace-debugger-stacktrace-verbose flag to add tracing for these cases.
TEST=ci (tested manually, only affects debugging output)
Change-Id: I2978d540f41b444251a61b62a57b6785a3dd8df0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467300
Auto-Submit: Tess Strickland <sstr...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M runtime/vm/debugger.cc
- M runtime/vm/debugger.h
Change size: M
Delta: 2 files changed, 81 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages