[L] Change in dart/sdk[main]: [DDS] Deprecate DDS APIs related to CPU sample caching
0 views
Skip to first unread message
Derek Xu (Gerrit)
Aug 8, 2025, 11:13:13 AM8/8/25
to Ben Konyi, Commit Queue, rev...@dartlang.org
Derek Xu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 8, 2025, 11:45:16 AM8/8/25
to Derek Xu, Ben Konyi, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/dds/test/get_cached_cpu_samples_test.dart
Insertions: 2, Deletions: 0.
@@ -38,6 +38,7 @@
// returns an [AvailableCachedCpuSamples] object containing a single
// property named `cacheNames` with an empty array as its value.
final availableCachedCpuSamples =
+ // ignore: deprecated_member_use
await service.getAvailableCachedCpuSamples();
expect(availableCachedCpuSamples.cacheNames.length, 0);
@@ -45,6 +46,7 @@
// _CachedCpuSamples_ object containing properties with meaningless
// placeholder values.
final cachedCpuSamples =
+ // ignore: deprecated_member_use
await service.getCachedCpuSamples('fake', 'fake');
expect(cachedCpuSamples.userTag, '');
expect(cachedCpuSamples.samplePeriod, -1);
```
Change information
Commit message:
[DDS] Deprecate DDS APIs related to CPU sample caching
- Deprecate `getAvailableCachedCpuSamples` and `getCachedCpuSamples` RPCs.
- Deprecate the `cachedUserTags` parameter of `DartDevelopmentService.startDartDevelopmentService`.
- Deprecate the `DartDevelopmentService.cachedUserTags` getter.
Change-Id: I9f9088a810584c2031d8475c767a312dff6ab2cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444100
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Derek Xu <der...@google.com>
Files:
- M pkg/dds/CHANGELOG.md
- M pkg/dds/dds_protocol.md
- M pkg/dds/lib/dds.dart
- M pkg/dds/lib/dds_launcher.dart
- M pkg/dds/lib/src/arg_parser.dart
- M pkg/dds/lib/src/client.dart
- D pkg/dds/lib/src/cpu_samples_manager.dart
- M pkg/dds/lib/src/dds_cli_entrypoint.dart
- M pkg/dds/lib/src/dds_impl.dart
- M pkg/dds/lib/src/isolate_manager.dart
- M pkg/dds/lib/src/stream_manager.dart
- M pkg/dds/pubspec.yaml
- M pkg/dds/test/get_cached_cpu_samples_test.dart
- M pkg/dds_service_extensions/CHANGELOG.md
- M pkg/dds_service_extensions/lib/dds_service_extensions.dart
- M pkg/dds_service_extensions/pubspec.yaml
Change size: L
Delta: 16 files changed, 83 insertions(+), 427 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ben Konyi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages