[S] Change in dart/sdk[main]: analyzer: Add unused_shown_name test case for dot-shorthands

0 views
Skip to first unread message

Samuel Rawlins (Gerrit)

unread,
Dec 18, 2025, 11:13:29 AM (3 days ago) Dec 18
to Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Does this look right to you, Kallen?

Open in Gerrit

Related details

Attention is currently required from:
  • Kallen Tu
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie0860dc1c80a5835959ec238fce98ff045e99940
Gerrit-Change-Number: 469080
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Kallen Tu <kall...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:13:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Kallen Tu (Gerrit)

unread,
Dec 18, 2025, 1:26:12 PM (3 days ago) Dec 18
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Kallen Tu voted and added 1 comment

Votes added by Kallen Tu

Code-Review+1

1 comment

Patchset-level comments
Kallen Tu . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0860dc1c80a5835959ec238fce98ff045e99940
    Gerrit-Change-Number: 469080
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 18:26:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Dec 18, 2025, 2:22:07 PM (3 days ago) Dec 18
    to Paul Berry, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Paul Berry

    Samuel Rawlins voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Paul Berry
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0860dc1c80a5835959ec238fce98ff045e99940
    Gerrit-Change-Number: 469080
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 19:22:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Dec 18, 2025, 2:25:21 PM (3 days ago) Dec 18
    to Samuel Rawlins, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Samuel Rawlins

    Paul Berry voted and added 1 comment

    Votes added by Paul Berry

    Code-Review+1
    Commit-Queue+2

    1 comment

    Patchset-level comments
    Paul Berry . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Samuel Rawlins
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0860dc1c80a5835959ec238fce98ff045e99940
    Gerrit-Change-Number: 469080
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 19:25:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Dec 18, 2025, 2:25:33 PM (3 days ago) Dec 18
    to Samuel Rawlins, Paul Berry, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    analyzer: Add unused_shown_name test case for dot-shorthands
    Change-Id: Ie0860dc1c80a5835959ec238fce98ff045e99940
    Reviewed-by: Paul Berry <paul...@google.com>
    Commit-Queue: Paul Berry <paul...@google.com>
    Auto-Submit: Samuel Rawlins <sraw...@google.com>
    Reviewed-by: Kallen Tu <kall...@google.com>
    Files:
    • M pkg/analyzer/test/src/diagnostics/unused_shown_name_test.dart
    Change size: S
    Delta: 1 file changed, 19 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Paul Berry, +1 by Kallen Tu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0860dc1c80a5835959ec238fce98ff045e99940
    Gerrit-Change-Number: 469080
    Gerrit-PatchSet: 2
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages