[M] Change in dart/sdk[main]: analyzer: Move errorRange utilities to public API
Samuel Rawlins (Gerrit)
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Commit-Queue | +1 |
1 comment
If you think these two getters should instead move to the AST classes themselves, I can refactor this.
Related details
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Friendly ping
Related details
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
Not sure how I feel about this. Why do we do this? Linter already can use it, and we can change both analyzer and linter atomically as needed. Making it official API though... Now we have to support it.
Related details
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Not sure how I feel about this. Why do we do this? Linter already can use it, and we can change both analyzer and linter atomically as needed. Making it official API though... Now we have to support it.
Ah, I thought we were on a quest to make anything the linter uses live in public API, as it is an indication that it is sensible to want/use this utility if you are writing an analysis rule.
I can bring it up in the Model team meeting; it's not crucial for me, or important anytime soon.
Related details
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
Samuel RawlinsNot sure how I feel about this. Why do we do this? Linter already can use it, and we can change both analyzer and linter atomically as needed. Making it official API though... Now we have to support it.
Ah, I thought we were on a quest to make anything the linter uses live in public API, as it is an indication that it is sensible to want/use this utility if you are writing an analysis rule.
I can bring it up in the Model team meeting; it's not crucial for me, or important anytime soon.
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Samuel RawlinsNot sure how I feel about this. Why do we do this? Linter already can use it, and we can change both analyzer and linter atomically as needed. Making it official API though... Now we have to support it.
Konstantin ShcheglovAh, I thought we were on a quest to make anything the linter uses live in public API, as it is an indication that it is sensible to want/use this utility if you are writing an analysis rule.
I can bring it up in the Model team meeting; it's not crucial for me, or important anytime soon.
Yes, lets discuss it.
Okie doke, discussed, and switched from extension to AST members proper.
Related details
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
analyzer: Move errorRange utilities to public API
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/src/dart/ast/ast.dart
- M pkg/analyzer/lib/src/dart/ast/extensions.dart
- M pkg/analyzer/lib/src/error/constructor_fields_verifier.dart
- M pkg/analyzer/lib/src/error/deprecated_functionality_verifier.dart
- M pkg/analyzer/lib/src/error/listener.dart
- M pkg/analyzer/lib/src/error/member_duplicate_definition_verifier.dart
- M pkg/linter/lib/src/rules/deprecated_consistency.dart
- M pkg/linter/lib/src/rules/prefer_const_constructors_in_immutables.dart
- M pkg/linter/lib/src/rules/sort_constructors_first.dart
- M pkg/linter/lib/src/rules/sort_unnamed_constructors_first.dart
- M pkg/linter/lib/src/rules/use_super_parameters.dart
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |