[S] Change in dart/sdk[main]: Fix a crash resulting from attempting to access a null URI when runni...
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Dec 29, 2025, 8:17:24 PM (2 days ago) Dec 29
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart
Related details
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fedor Shcheglov (Gerrit)
Dec 29, 2025, 8:18:46 PM (2 days ago) Dec 29
to Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Fedor Shcheglov added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart
Line 710, Patchset 1:
''');Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 29, 2025, 8:19:11 PM (2 days ago) Dec 29
to Fedor Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 29, 2025, 8:54:09 PM (2 days ago) Dec 29
to Fedor Shcheglov, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 29, 2025, 9:05:04 PM (2 days ago) Dec 29
to Fedor Shcheglov, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 29, 2025, 9:05:13 PM (2 days ago) Dec 29
to Fedor Shcheglov, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix a crash resulting from attempting to access a null URI when running package_names lint during code actions.
Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/470060
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/pubspec.dart
- M pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart
Change size: S
Delta: 2 files changed, 16 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages