[S] Change in dart/sdk[main]: Fix a crash resulting from attempting to access a null URI when runni...

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Dec 29, 2025, 8:17:24 PM (2 days ago) Dec 29
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov added 1 comment

File pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart
Line 710, Patchset 1: ''');
Konstantin Shcheglov . unresolved

Remove spaces.

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
Gerrit-Change-Number: 470060
Gerrit-PatchSet: 1
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Dec 2025 01:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Fedor Shcheglov (Gerrit)

unread,
Dec 29, 2025, 8:18:46 PM (2 days ago) Dec 29
to Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Fedor Shcheglov added 1 comment

File pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart
Konstantin Shcheglov . resolved

Remove spaces.

Fedor Shcheglov

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
Gerrit-Change-Number: 470060
Gerrit-PatchSet: 2
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Tue, 30 Dec 2025 01:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Dec 29, 2025, 8:19:11 PM (2 days ago) Dec 29
to Fedor Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
    Gerrit-Change-Number: 470060
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Tue, 30 Dec 2025 01:19:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Dec 29, 2025, 8:54:09 PM (2 days ago) Dec 29
    to Fedor Shcheglov, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov

    Samuel Rawlins voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
    Gerrit-Change-Number: 470060
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Tue, 30 Dec 2025 01:54:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Dec 29, 2025, 9:05:04 PM (2 days ago) Dec 29
    to Fedor Shcheglov, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov

    Konstantin Shcheglov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
    Gerrit-Change-Number: 470060
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Tue, 30 Dec 2025 02:05:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Dec 29, 2025, 9:05:13 PM (2 days ago) Dec 29
    to Fedor Shcheglov, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    Fix a crash resulting from attempting to access a null URI when running package_names lint during code actions.
    Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Commit-Queue: Konstantin Shcheglov <sche...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/lsp/handlers/code_actions/pubspec.dart
    • M pkg/analysis_server/test/shared/shared_code_actions_fixes_tests.dart
    Change size: S
    Delta: 2 files changed, 16 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ad16c5316ba08eb77109803d09b210135639be4
    Gerrit-Change-Number: 470060
    Gerrit-PatchSet: 4
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages