[M] Change in dart/sdk[main]: CQ. Remove not useful PubSuggestionCodeTest, tweak for encoding test.
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Jun 8, 2026, 6:36:47 PM (3 days ago) Jun 8
to Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry
Konstantin Shcheglov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Jun 9, 2026, 6:22:19 AM (3 days ago) Jun 9
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johnni Winther
| Code-Review | +1 |
1 comment
File pkg/analyzer/test/generated/non_hint_code_test.dart
Line 146, Patchset 1 (Parent):
// TODO(brianwilkerson): The tests in this class are not being run, and all but
// the first would fail. We should implement these checks and enable the
// tests.
test_import_package() async {Johnni Winther . unresolved
Why should we not implement these checks?
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 9, 2026, 1:19:01 PM (2 days ago) Jun 9
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Commit-Queue | +2 |
1 comment
File pkg/analyzer/test/generated/non_hint_code_test.dart
Line 146, Patchset 1 (Parent):
// TODO(brianwilkerson): The tests in this class are not being run, and all but
// the first would fail. We should implement these checks and enable the
// tests.
test_import_package() async {Johnni Winther . resolved
Why should we not implement these checks?
Konstantin Shcheglov
I have no idea what these checks are, and I have not seen / heard this name "pub suggestion" for a long time. So, I think this is stale code / idea now.
Related details
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 1:49:02 PM (2 days ago) Jun 9
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CQ. Remove not useful PubSuggestionCodeTest, tweak for encoding test.
Change-Id: I08f5da69db285395566e71463e4e357ea4227ac2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510201
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/test/generated/invalid_code_test.dart
- M pkg/analyzer/test/generated/non_hint_code_test.dart
Change size: M
Delta: 2 files changed, 1 insertion(+), 79 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages