[XS] Change in dart/sdk[main]: [dartdev] Fix test package resolution
0 views
Skip to first unread message
Daco Harkes (Gerrit)
Jun 9, 2026, 3:04:18 AM (yesterday) Jun 9
to Alexander Thomas, Bob Nystrom, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Alexander Thomas and Bob Nystrom
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Thomas
- Bob Nystrom
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Thomas (Gerrit)
Jun 9, 2026, 3:04:18 AM (yesterday) Jun 9
to Daco Harkes, Bob Nystrom, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Bob Nystrom and Daco Harkes
Alexander Thomas voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Bob Nystrom
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jun 9, 2026, 4:26:32 AM (yesterday) Jun 9
to Alexander Thomas, Bob Nystrom, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Bob Nystrom
Daco Harkes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Bob Nystrom
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 4:26:48 AM (yesterday) Jun 9
to Daco Harkes, Alexander Thomas, Bob Nystrom, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/dartdev/test/native_assets/helpers.dart
Insertions: 1, Deletions: 1.
@@ -133,7 +133,7 @@
.toFilePath(),
},
for (final package in [
- 'analyzer', // package:meta depends on package:analyzer.
+ 'analyzer', // package:analyzer depends on package:meta.
'meta',
])
package: {'path': sdkRoot.resolve('pkg/$package/').toFilePath()},
```
Change information
Commit message:
[dartdev] Fix test package resolution
Change-Id: I6d0d9fd29dd7eafcbf7d451b3f91ca66cc8c7fe7
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510300
Reviewed-by: Alexander Thomas <at...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Files:
- M pkg/dartdev/test/native_assets/helpers.dart
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Thomas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Nystrom (Gerrit)
Jun 9, 2026, 9:24:28 AM (yesterday) Jun 9
to Daco Harkes, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Thomas, rev...@dartlang.org
Bob Nystrom voted Code-Review+1![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages