[S] Change in dart/sdk[main]: [sdk/vm] Make Encoding._nameToEncoding map const.
0 views
Skip to first unread message
Slava Egorov (Gerrit)
Nov 14, 2025, 5:23:39 PMNov 14
to Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Nov 14, 2025, 7:12:21 PMNov 14
to Alexander Aprelev, Slava Egorov, Commit Queue, rev...@dartlang.org
Alexander Aprelev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Aprelev
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Nov 14, 2025, 7:18:13 PMNov 14
to Alexander Aprelev, Martin Kustermann, Stephen Adams, Lasse Nielsen, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Lasse Nielsen, Martin Kustermann and Stephen Adams
Alexander Aprelev added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alexander Aprelev . resolved
for Core-Library-Review requirement
Related details
Attention is currently required from:
- Lasse Nielsen
- Martin Kustermann
- Stephen Adams
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Nov 17, 2025, 5:41:52 AMNov 17
to Alexander Aprelev, Stephen Adams, Lasse Nielsen, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev, Lasse Nielsen and Stephen Adams
Martin Kustermann voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Aprelev
- Lasse Nielsen
- Stephen Adams
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Nov 17, 2025, 12:13:31 PMNov 17
to Alexander Aprelev, Martin Kustermann, Stephen Adams, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev and Stephen Adams
Lasse Nielsen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lasse Nielsen
| Code-Review | +1 |
1 comment
File sdk/lib/convert/encoding.dart
Line 47, Patchset 4 (Latest):
static const Map<String, Encoding> _nameToEncoding = const <String, Encoding>{Lasse Nielsen . resolved
This makes it certain that we won't allow user-added encodings.
Probably for the best. They should not be modifiying global values.
Related details
Attention is currently required from:
- Alexander Aprelev
- Stephen Adams
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigmund Cherem (Gerrit)
Dec 1, 2025, 8:32:57 PM (15 hours ago) Dec 1
to Alexander Aprelev, Sigmund Cherem, Lasse Nielsen, Martin Kustermann, Stephen Adams, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev and Stephen Adams
Sigmund Cherem voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Aprelev
- Stephen Adams
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
8:51 AM (3 hours ago) 8:51 AM
to Alexander Aprelev, Sigmund Cherem, Lasse Nielsen, Martin Kustermann, Stephen Adams, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Stephen Adams
Alexander Aprelev voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Stephen Adams
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
8:51 AM (3 hours ago) 8:51 AM
to Alexander Aprelev, Sigmund Cherem, Lasse Nielsen, Martin Kustermann, Stephen Adams, Slava Egorov, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tests/ffi/run_isolate_group_run_test.dart
Insertions: 11, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[sdk/vm] Make Encoding._nameToEncoding map const.
This allows use of Encoding class in isolategroup-bound callbacks.
TEST=run_isolate_group_run_test
BUG=https://github.com/dart-lang/sdk/issues/61541
Change-Id: Iaa545bc2df7ffd98e9fc09381826c566f4b833ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461185
Reviewed-by: Slava Egorov <veg...@google.com>
Reviewed-by: Martin Kustermann <kuste...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Reviewed-by: Lasse Nielsen <l...@google.com>
Reviewed-by: Sigmund Cherem <sig...@google.com>
Files:
- M sdk/lib/convert/encoding.dart
- M tests/ffi/run_isolate_group_run_test.dart
Change size: XS
Delta: 2 files changed, 8 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lasse Nielsen, +1 by Sigmund Cherem, +1 by Slava Egorov, +1 by Martin Kustermann
Core-Library-Review: Code-Review+1 by Lasse Nielsen, Code-Review+1 by Sigmund Cherem, Code-Review+1 by Slava Egorov, Code-Review+1 by Martin Kustermann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
10:21 AM (1 hour ago) 10:21 AM
to Alexander Aprelev, Commit Queue, Sigmund Cherem, Martin Kustermann, Stephen Adams, Slava Egorov, rev...@dartlang.org
Attention needed from Alexander Aprelev
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
File tests/ffi/run_isolate_group_run_test.dart
Line 278, Patchset 6:
() => Encoding.getByName("us-ascii")!.encode("123abc"),Lasse Nielsen . unresolved
Late comment: Consider testing the object, not its behavior.
(This test would be accepted even if `Encoding.getByName` always returned `utf8` when run in an isolate group).
```dart
Expect.isTrue(
IsolateGroup.runSync(() => identical(Encoding.getByName("us-ascii"), ascii));
Expect.isTrue(
IsolateGroup.runSync(() => identical(Encoding.getByName("utf-8"), utf8));
```
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages