[XL] Change in dart/sdk[main]: [cfe] Add _PreBuilder

[Chloe Stefantsova (Gerrit)]

Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Johnni Winther

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Comment-Date: Mon, 25 Nov 2024 14:22:34 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Johnni Winther (Gerrit)]

Attention needed from Erik Ernst

Johnni Winther added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Johnni Winther . resolved

@eer...@google.com can you review the language test changes?

Open in Gerrit

Related details

Attention is currently required from:

• Erik Ernst

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Erik Ernst <eer...@google.com>

Gerrit-Comment-Date: Mon, 25 Nov 2024 16:39:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Erik Ernst (Gerrit)]

Attention needed from Johnni Winther

Erik Ernst added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Johnni Winther . resolved

@eer...@google.com can you review the language test changes?

Erik Ernst

Certainly! I'll get around to look at it tomorrow.

Open in Gerrit

Related details

Attention is currently required from:

• Johnni Winther

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Comment-Date: Mon, 25 Nov 2024 19:26:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Johnni Winther <johnni...@google.com>

[Erik Ernst (Gerrit)]

Attention needed from Johnni Winther

Erik Ernst added 2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Erik Ernst . resolved

At first I was quite confused about the language test changes: Nothing changes except that some error messages (e.g., about static/instance member conflicts) are no longer reported, and other error messages are more informative than they used to be. However, Chloe explained that this CL is about a rather large scale refactoring, and the changes in error messaging isn't the point (and the disappearing messages will be restored later as needed).

So LGTM.

File tests/language/extension_methods/static_extension_internal_name_conflict_error_test.dart

Line 62, Patchset 6 (Parent): // [cfe] Conflicts with setter 'field2'.

Erik Ernst . unresolved

I don't quite understand why this error would disappear, or why this declaration would conflict with the setter named `field2` (line 82 on the right hand side of the diff) and not with the getter (line 78).

Or does the error message mean "something whose name shall remain unspoken creates 'conflicts with setter `field2`', which is a reference to the implicitly induced setter of the variable declared on line 60?

Anyway, I'm confused. ;-)

Open in Gerrit

Related details

Attention is currently required from:

• Johnni Winther

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Comment-Date: Tue, 26 Nov 2024 09:49:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Erik Ernst (Gerrit)]

Attention needed from Johnni Winther

Erik Ernst voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Johnni Winther

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Comment-Date: Tue, 26 Nov 2024 09:49:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Johnni Winther (Gerrit)]

Johnni Winther added 1 comment

File tests/language/extension_methods/static_extension_internal_name_conflict_error_test.dart

Line 62, Patchset 6 (Parent): // [cfe] Conflicts with setter 'field2'.

Erik Ernst . resolved

I don't quite understand why this error would disappear, or why this declaration would conflict with the setter named `field2` (line 82 on the right hand side of the diff) and not with the getter (line 78).

Or does the error message mean "something whose name shall remain unspoken creates 'conflicts with setter `field2`', which is a reference to the implicitly induced setter of the variable declared on line 60?

Anyway, I'm confused. ;-)

Johnni Winther

The change makes it so that an error is reported on the second occurrence and the first is used as context. Previously we reported error on both. So for this case we previously had an error on lines 60 and 80, whereas now we have an error on line 80 and the context on line 60. This means that conflicts with setters now are reported similar to duplicate declarations. Unfortunately the static error test doesn't show the context making it look like we no longer report the error in one of the cases.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Comment-Date: Wed, 27 Nov 2024 08:31:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Erik Ernst <eer...@google.com>

[Erik Ernst (Gerrit)]

Attention needed from Johnni Winther

Erik Ernst added 1 comment

File tests/language/extension_methods/static_extension_internal_name_conflict_error_test.dart

Line 62, Patchset 6 (Parent): // [cfe] Conflicts with setter 'field2'.

Erik Ernst . resolved

I don't quite understand why this error would disappear, or why this declaration would conflict with the setter named `field2` (line 82 on the right hand side of the diff) and not with the getter (line 78).

Or does the error message mean "something whose name shall remain unspoken creates 'conflicts with setter `field2`', which is a reference to the implicitly induced setter of the variable declared on line 60?

Anyway, I'm confused. ;-)

Johnni Winther

The change makes it so that an error is reported on the second occurrence and the first is used as context. Previously we reported error on both. So for this case we previously had an error on lines 60 and 80, whereas now we have an error on line 80 and the context on line 60. This means that conflicts with setters now are reported similar to duplicate declarations. Unfortunately the static error test doesn't show the context making it look like we no longer report the error in one of the cases.

Erik Ernst

OK, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Johnni Winther

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 6

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Comment-Date: Wed, 27 Nov 2024 08:47:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Johnni Winther <johnni...@google.com>

Comment-In-Reply-To: Erik Ernst <eer...@google.com>

[Johnni Winther (Gerrit)]

Attention needed from Chloe Stefantsova and Erik Ernst

Johnni Winther added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Johnni Winther . resolved

PRA (=Please Re-Approve) - Gerrit stabbed us in the back again.

Open in Gerrit

Related details

Attention is currently required from:

• Chloe Stefantsova
• Erik Ernst

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 7

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Erik Ernst <eer...@google.com>

Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Comment-Date: Wed, 27 Nov 2024 09:03:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Erik Ernst (Gerrit)]

Attention needed from Chloe Stefantsova and Johnni Winther

Erik Ernst voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Chloe Stefantsova
• Johnni Winther

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 7

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Johnni Winther <johnni...@google.com>

Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Comment-Date: Wed, 27 Nov 2024 09:15:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Johnni Winther (Gerrit)]

Attention needed from Chloe Stefantsova

Johnni Winther voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Chloe Stefantsova

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 7

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Paul Berry <paul...@google.com>

Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Comment-Date: Wed, 27 Nov 2024 09:29:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Commit Queue (Gerrit)]

Commit Queue submitted the change

Change information

Commit message:

[cfe] Add _PreBuilder

This moves the checking of duplicates, member/setter, and static/instance conflicts to a _PreBuilder.

Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397163

Reviewed-by: Erik Ernst <eer...@google.com>

Commit-Queue: Johnni Winther <johnni...@google.com>

Files:

• M pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart
• M pkg/front_end/lib/src/base/uri_translator.dart
• M pkg/front_end/lib/src/fragment/field.dart
• M pkg/front_end/lib/src/kernel/hierarchy/members_node.dart
• M pkg/front_end/lib/src/source/outline_builder.dart
• M pkg/front_end/lib/src/source/source_builder_mixins.dart
• M pkg/front_end/lib/src/source/source_class_builder.dart
• M pkg/front_end/lib/src/source/source_extension_type_declaration_builder.dart
• M pkg/front_end/lib/src/source/source_library_builder.dart
• M pkg/front_end/lib/src/source/type_parameter_scope_builder.dart
• M pkg/front_end/messages.status
• M pkg/front_end/messages.yaml
• M pkg/front_end/test/coverage_suite_expected.dart
• M pkg/front_end/test/spell_checking_list_code.txt
• M pkg/front_end/testcases/constructor_tearoffs/lowering/duplicate_typedefs.dart.strong.expect
• M pkg/front_end/testcases/constructor_tearoffs/lowering/duplicate_typedefs.dart.strong.modular.expect
• M pkg/front_end/testcases/constructor_tearoffs/lowering/duplicate_typedefs.dart.strong.outline.expect
• M pkg/front_end/testcases/constructor_tearoffs/lowering/duplicate_typedefs.dart.strong.transformed.expect
• M pkg/front_end/testcases/extension_types/constructor_vs_static_member.dart.strong.expect
• M pkg/front_end/testcases/extension_types/constructor_vs_static_member.dart.strong.modular.expect
• M pkg/front_end/testcases/extension_types/constructor_vs_static_member.dart.strong.outline.expect
• M pkg/front_end/testcases/extension_types/constructor_vs_static_member.dart.strong.transformed.expect
• M pkg/front_end/testcases/extension_types/implements_conflicts.dart.strong.expect
• M pkg/front_end/testcases/extension_types/implements_conflicts.dart.strong.modular.expect
• M pkg/front_end/testcases/extension_types/implements_conflicts.dart.strong.outline.expect
• M pkg/front_end/testcases/extension_types/implements_conflicts.dart.strong.transformed.expect
• M pkg/front_end/testcases/extensions/extension_member_conflict.dart.strong.expect
• M pkg/front_end/testcases/extensions/extension_member_conflict.dart.strong.modular.expect
• M pkg/front_end/testcases/extensions/extension_member_conflict.dart.strong.outline.expect
• M pkg/front_end/testcases/extensions/extension_member_conflict.dart.strong.transformed.expect
• M pkg/front_end/testcases/extensions/issue38713.dart.strong.expect
• M pkg/front_end/testcases/extensions/issue38713.dart.strong.modular.expect
• M pkg/front_end/testcases/extensions/issue38713.dart.strong.outline.expect
• M pkg/front_end/testcases/extensions/issue38713.dart.strong.transformed.expect
• M pkg/front_end/testcases/extensions/issue38745.dart.strong.expect
• M pkg/front_end/testcases/extensions/issue38745.dart.strong.modular.expect
• M pkg/front_end/testcases/extensions/issue38745.dart.strong.outline.expect
• M pkg/front_end/testcases/extensions/issue38745.dart.strong.transformed.expect
• A pkg/front_end/testcases/general/const_vs_setter.dart
• A pkg/front_end/testcases/general/const_vs_setter.dart.strong.expect
• A pkg/front_end/testcases/general/const_vs_setter.dart.strong.modular.expect
• A pkg/front_end/testcases/general/const_vs_setter.dart.strong.outline.expect
• A pkg/front_end/testcases/general/const_vs_setter.dart.strong.transformed.expect
• A pkg/front_end/testcases/general/const_vs_setter.dart.textual_outline.expect
• A pkg/front_end/testcases/general/const_vs_setter.dart.textual_outline_modelled.expect
• M pkg/front_end/testcases/general/duplicated_declarations.dart.strong.expect
• M pkg/front_end/testcases/general/duplicated_declarations.dart.strong.modular.expect
• M pkg/front_end/testcases/general/duplicated_declarations.dart.strong.outline.expect
• M pkg/front_end/testcases/general/duplicated_declarations.dart.strong.transformed.expect
• M pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.expect
• M pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.modular.expect
• M pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.outline.expect
• M pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.transformed.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_bad_name_general.crash_dart.strong.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_bad_name_general.crash_dart.strong.modular.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_bad_name_general.crash_dart.strong.outline.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_bad_name_general.crash_dart.strong.transformed.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_operator.crash_dart.strong.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_operator.crash_dart.strong.modular.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_operator.crash_dart.strong.outline.expect
• M pkg/front_end/testcases/general/error_recovery/constructor_recovery_operator.crash_dart.strong.transformed.expect
• M pkg/front_end/testcases/general/hierarchy/conflict.dart.strong.expect
• M pkg/front_end/testcases/general/hierarchy/conflict.dart.strong.modular.expect
• M pkg/front_end/testcases/general/hierarchy/conflict.dart.strong.outline.expect
• M pkg/front_end/testcases/general/issue41842.dart.strong.expect
• M pkg/front_end/testcases/general/issue41842.dart.strong.modular.expect
• M pkg/front_end/testcases/general/issue41842.dart.strong.outline.expect
• M pkg/front_end/testcases/general/issue41842.dart.strong.transformed.expect
• M pkg/front_end/testcases/macros/augment_class.dart.strong.expect
• M pkg/front_end/testcases/macros/augment_class.dart.strong.modular.expect
• M pkg/front_end/testcases/macros/augment_class.dart.strong.outline.expect
• M pkg/front_end/testcases/macros/augment_class.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance.dart.strong.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance_extension.dart.strong.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance_extension.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance_extension.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/duplicates_instance_extension.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/duplicates_static.dart.strong.expect
• M pkg/front_end/testcases/nnbd/duplicates_static.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/duplicates_static.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/duplicates_static.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/duplicates_static_extension.dart.strong.expect
• M pkg/front_end/testcases/nnbd/duplicates_static_extension.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/duplicates_static_extension.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/duplicates_static_extension.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/duplicates_toplevel.dart.strong.expect
• M pkg/front_end/testcases/nnbd/duplicates_toplevel.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/duplicates_toplevel.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/duplicates_toplevel.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/field_setter_conflict.dart.strong.expect
• M pkg/front_end/testcases/nnbd/field_setter_conflict.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/field_setter_conflict.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/field_setter_conflict.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/field_vs_setter.dart.strong.expect
• M pkg/front_end/testcases/nnbd/field_vs_setter.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/field_vs_setter.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/field_vs_setter.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/instance_duplicates.dart.strong.expect
• M pkg/front_end/testcases/nnbd/instance_duplicates.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/instance_duplicates.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/instance_duplicates.dart.strong.transformed.expect
• M pkg/front_end/testcases/nnbd/nonfield_vs_setter.dart.strong.expect
• M pkg/front_end/testcases/nnbd/nonfield_vs_setter.dart.strong.modular.expect
• M pkg/front_end/testcases/nnbd/nonfield_vs_setter.dart.strong.outline.expect
• M pkg/front_end/testcases/nnbd/nonfield_vs_setter.dart.strong.transformed.expect
• M pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.strong.expect
• M pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.strong.modular.expect
• M pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.strong.outline.expect
• M pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.strong.transformed.expect
• M pkg/front_end/testcases/rasta/super.dart.strong.expect
• M pkg/front_end/testcases/rasta/super.dart.strong.modular.expect
• M pkg/front_end/testcases/rasta/super.dart.strong.outline.expect
• M pkg/front_end/testcases/rasta/super.dart.strong.transformed.expect
• M pkg/front_end/testcases/regress/utf_16_le_content.crash_dart.strong.expect
• M pkg/front_end/testcases/regress/utf_16_le_content.crash_dart.strong.modular.expect
• M pkg/front_end/testcases/regress/utf_16_le_content.crash_dart.strong.outline.expect
• M pkg/front_end/testcases/regress/utf_16_le_content.crash_dart.strong.transformed.expect
• M tests/language/extension_methods/static_extension_internal_name_conflict_error_test.dart
• M tests/language/field/field1_test.dart
• M tests/language/field/field2_test.dart
• M tests/language/regress/regress33235_01_test.dart
• M tests/language/regress/regress33235_02_test.dart
• M tests/language/regress/regress33235_03_test.dart
• M tests/language/regress/regress33235_07_test.dart
• M tests/language/regress/regress33235_10_test.dart
• M tests/language/regress/regress33235_11_test.dart
• M tests/language/regress/regress33235_12_test.dart
• M tests/language/regress/regress33235_13_test.dart
• M tests/language/regress/regress33235_16_test.dart
• M tests/language/setter/setter4_test.dart
• M tests/language/unsorted/bad_override_test.dart

Change size: XL

Delta: 134 files changed, 5781 insertions(+), 5177 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Erik Ernst

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I85f33750c1579676696223d1b19019887ae41e50

Gerrit-Change-Number: 397163

Gerrit-PatchSet: 8

Gerrit-Owner: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>

Gerrit-Reviewer: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Erik Ernst <eer...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-CC: Paul Berry <paul...@google.com>