[S] Change in dart/sdk[main]: add appName to startDartDevelopmentService, forward to DTD
Jake Macdonald (Gerrit)
Jake Macdonald voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- Ben Konyi
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Ben Konyi added 3 comments![]( "Open in Gerrit")
- Add `appName` parameter to `DartDevelopmentService.startDartDevelopmentService`.`DartDevelopmentService` is deprecated and won't be public in the future, so it's not worth documenting this here.
String? appName,You'd need to add this as a parameter to `DartDevelopmentServiceLauncher`, since that's what's used to launch DDS from most tools.
/// The name of the application that is being served by the vm service ifNit: "VM service"
Also, the VM service doesn't serve applications, so this is incorrect. Consider:
"The name of the application associated with the VM service"
Related details
- Jake Macdonald
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jake Macdonald voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jake Macdonald
| Auto-Submit | +1 |
| Commit-Queue | +1 |
3 comments
- Add `appName` parameter to `DartDevelopmentService.startDartDevelopmentService`.`DartDevelopmentService` is deprecated and won't be public in the future, so it's not worth documenting this here.
Done
String? appName,You'd need to add this as a parameter to `DartDevelopmentServiceLauncher`, since that's what's used to launch DDS from most tools.
Done
/// The name of the application that is being served by the vm service ifNit: "VM service"
Also, the VM service doesn't serve applications, so this is incorrect. Consider:
"The name of the application associated with the VM service"
- Ben Konyi
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jake Macdonald voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jake Macdonald
| Auto-Submit | +1 |
1 comment
"runtime_precompiled"Should this runtime_precompiled one still be here?
Related details
- Ben Konyi
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jake Macdonald voted Commit-Queue+1![]( "Open in Gerrit")
- Ben Konyi
- Brian Quinlan
- Jake Macdonald
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jake Macdonald added 1 comment![]( "Open in Gerrit")
"create_sdk"Do let me know in general if I should be doing something different.
What I actually want here is for the DTD snapshot to be built, since the DDS tests now will actually launch it.
Related details
- Ben Konyi
- Ryan Macnak
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Ben Konyi added 1 comment![]( "Open in Gerrit")
"create_sdk"Do let me know in general if I should be doing something different.
What I actually want here is for the DTD snapshot to be built, since the DDS tests now will actually launch it.
We almost certainly don't want to do this since it'll increase build times and actually isn't going to generate the right binaries for these builders (e.g., `run_vm_tests` isn't created by `create_sdk`).
Related details
- Jake Macdonald
- Ryan Macnak
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jake Macdonald added 1 comment![]( "Open in Gerrit")
"create_sdk"Ben KonyiDo let me know in general if I should be doing something different.
What I actually want here is for the DTD snapshot to be built, since the DDS tests now will actually launch it.
We almost certainly don't want to do this since it'll increase build times and actually isn't going to generate the right binaries for these builders (e.g., `run_vm_tests` isn't created by `create_sdk`).
- Ben Konyi
- Ryan Macnak
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |