[S] Change in dart/sdk[main]: [deps] Roll dart-lang/native
0 views
Skip to first unread message
Daco Harkes (Gerrit)
Jun 30, 2026, 9:05:23 AMJun 30
to Michael Goderbauer, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Michael Goderbauer
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Goderbauer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jun 30, 2026, 10:44:05 AMJun 30
to Michael Goderbauer, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Michael Goderbauer
Daco Harkes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daco Harkes . resolved
We need https://github.com/dart-lang/native/pull/3442 to skip dumpbin on the CI here.
Related details
Attention is currently required from:
- Michael Goderbauer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Goderbauer (Gerrit)
Jul 1, 2026, 3:36:19 AMJul 1
to Daco Harkes, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Daco Harkes
Michael Goderbauer voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jul 1, 2026, 5:53:03 AMJul 1
to Michael Goderbauer, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Daco Harkes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 1, 2026, 6:14:27 AMJul 1
to Daco Harkes, Michael Goderbauer, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: DEPS
Insertions: 1, Deletions: 1.
@@ -136,7 +136,7 @@
"i18n_rev": "2ae32fdd9ca14ecdca77dc37787dbba3c9e2c48a",
"leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # rolled manually
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
- "native_rev": "c8b26f45853eb518a5191d2fc47e70d7f23e690c", # rolled manually while record_use is experimental
+ "native_rev": "81e464e7ff06aa66246b38a326025e3dba6928d3", # rolled manually while record_use is experimental
"protobuf_rev": "84079e8b8531309e06ba7276b1c28bdca9210ad6",
"pub_rev": "ec276d10a7fa0f6c6ec005340fb9ad29f3b012d0", # rolled manually
"shelf_rev": "74d58bc1499115f91f8120dbd08f77c83f7f343d",
```
Change information
Commit message:
[deps] Roll dart-lang/native
And update the roll skill
Change-Id: I2e97a47e73eac40515f2e28cdf8d9bfe75047f1e
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/518761
Reviewed-by: Michael Goderbauer <goder...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Files:
- M .agents/skills/update_native_rev/SKILL.md
- M DEPS
Change size: S
Delta: 2 files changed, 22 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Goderbauer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jul 10, 2026, 7:26:53 AM (6 days ago) Jul 10
to Michael Goderbauer, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Michael Goderbauer
Daco Harkes voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Goderbauer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Goderbauer (Gerrit)
Jul 10, 2026, 7:39:34 AM (6 days ago) Jul 10
to Daco Harkes, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Daco Harkes
Michael Goderbauer voted![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 10, 2026, 7:39:45 AM (6 days ago) Jul 10
to Daco Harkes, Michael Goderbauer, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[deps] Roll dart-lang/native
Package hooks now depends on record_use, so we need accompanying
dependency overrides so that the tests run with the version that's
pulled in via DEPS.
Change-Id: I3ca441669e679e7853415d2f49ffd39bab6991b9
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/523042
Commit-Queue: Michael Goderbauer <goder...@google.com>
Auto-Submit: Daco Harkes <dacoh...@google.com>
Reviewed-by: Michael Goderbauer <goder...@google.com>
Files:
- M DEPS
- M pkg/dartdev/test/native_assets/build_test.dart
- M pkg/dartdev/test/native_assets/install_test.dart
Change size: S
Delta: 3 files changed, 42 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Goderbauer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jul 10, 2026, 9:02:56 AM (6 days ago) Jul 10
to Michael Goderbauer, rev...@dartlang.org
Attention needed from Michael Goderbauer
Daco Harkes voted![]( "Open in Gerrit")
Attention is currently required from:
- Michael Goderbauer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Goderbauer (Gerrit)
Jul 10, 2026, 9:03:21 AM (6 days ago) Jul 10
to Daco Harkes, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Daco Harkes
Michael Goderbauer voted![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jul 10, 2026, 9:21:24 AM (6 days ago) Jul 10
to Michael Goderbauer, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Michael Goderbauer
Daco Harkes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Michael Goderbauer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Jul 13, 2026, 9:49:33 AM (3 days ago) Jul 13
to Michael Goderbauer, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Michael Goderbauer
Daco Harkes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Michael Goderbauer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 13, 2026, 10:02:08 AM (3 days ago) Jul 13
to Daco Harkes, Michael Goderbauer, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: DEPS
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[deps] Roll dart-lang/native
Roll in https://github.com/dart-lang/native/pull/3466 before
releasing hooks_runner to pub and rolling it to Flutter.
Change-Id: I63af3959d3d1098351da8a2cc67819276076b546
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/523080
Auto-Submit: Daco Harkes <dacoh...@google.com>
Reviewed-by: Michael Goderbauer <goder...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Files:
- M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Goderbauer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
2:30 PM (9 hours ago) 2:30 PM
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Nate Biggs
Daco Harkes voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
2:34 PM (9 hours ago) 2:34 PM
to Daco Harkes, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Daco Harkes
Nate Biggs voted![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
3:20 PM (8 hours ago) 3:20 PM
to Daco Harkes, Nate Biggs, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[deps] Roll dart-lang/native
Change-Id: Ide44cbe6d35337f25a1743d4c4e72262c790ddf7
Cq-Include-Trybots: luci.dart.try:pkg-win-release-try,pkg-mac-release-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-linux-release-arm64-try,pkg-linux-debug-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/524600
Auto-Submit: Daco Harkes <dacoh...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Commit-Queue: Nate Biggs <nate...@google.com>
Files:
- M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Biggs
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages