[S] Change in dart/sdk[main]: [private named parameters] Update diagnostic documentation.

0 views
Skip to first unread message

Bob Nystrom (Gerrit)

unread,
Dec 1, 2025, 1:43:45 PM (yesterday) Dec 1
to Brian Wilkerson, Connie Ooi, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Connie Ooi

Bob Nystrom voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Connie Ooi
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I06b3fefde12fbe8c4ddc176591c4932fe5b3b642
Gerrit-Change-Number: 465362
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Connie Ooi <conn...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Connie Ooi <conn...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 18:43:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Dec 1, 2025, 2:18:49 PM (yesterday) Dec 1
to Bob Nystrom, Brian Wilkerson, Commit Queue, Connie Ooi, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Bob Nystrom and Connie Ooi

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bob Nystrom
  • Connie Ooi
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I06b3fefde12fbe8c4ddc176591c4932fe5b3b642
Gerrit-Change-Number: 465362
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Connie Ooi <conn...@google.com>
Gerrit-Attention: Bob Nystrom <rnys...@google.com>
Gerrit-Attention: Connie Ooi <conn...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 19:18:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Connie Ooi (Gerrit)

unread,
Dec 1, 2025, 2:58:32 PM (yesterday) Dec 1
to Bob Nystrom, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Bob Nystrom

Connie Ooi voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bob Nystrom
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I06b3fefde12fbe8c4ddc176591c4932fe5b3b642
Gerrit-Change-Number: 465362
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Connie Ooi <conn...@google.com>
Gerrit-Attention: Bob Nystrom <rnys...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 19:58:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Bob Nystrom (Gerrit)

unread,
Dec 1, 2025, 5:34:49 PM (22 hours ago) Dec 1
to Connie Ooi, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Connie Ooi

Bob Nystrom voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Connie Ooi
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I06b3fefde12fbe8c4ddc176591c4932fe5b3b642
Gerrit-Change-Number: 465362
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Connie Ooi <conn...@google.com>
Gerrit-Attention: Connie Ooi <conn...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 22:34:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 1, 2025, 6:18:26 PM (21 hours ago) Dec 1
to Bob Nystrom, Connie Ooi, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[private named parameters] Update diagnostic documentation.

Applying Connie's review feedback from:

https://dart-review.googlesource.com/c/sdk/+/464605
Change-Id: I06b3fefde12fbe8c4ddc176591c4932fe5b3b642
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Connie Ooi <conn...@google.com>
Commit-Queue: Bob Nystrom <rnys...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>
Files:
  • M pkg/analyzer/messages.yaml
Change size: S
Delta: 1 file changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Connie Ooi, +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I06b3fefde12fbe8c4ddc176591c4932fe5b3b642
Gerrit-Change-Number: 465362
Gerrit-PatchSet: 2
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Connie Ooi <conn...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages