[L] Change in dart/sdk[main]: Add a lint to flag local variables created to promote `this`.
1 view
Skip to first unread message
Brian Wilkerson (Gerrit)
Jul 24, 2026, 9:38:38 AM (13 days ago) Jul 24
to Brian Wilkerson, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Jul 27, 2026, 2:00:24 PM (10 days ago) Jul 27
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Paul Berry voted and added 2 comments![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
2 comments
Patchset-level comments
File pkg/linter/lib/src/rules/unnecessary_this_alias.dart
Line 63, Patchset 2 (Latest):
IsExpression(:var expression) => expression == expr,Paul Berry . unresolved
I thought of a few other expressions that can promote too:
- `self?.property` (e.g., `self?.x = self.y`)
- `self?.method(...)` (e.g., `self?.f(self.x)`)
- `self?[...]` (e.g., `self?[self.x]` or `self?[self.x] = self.y`
- `self?..cascadeSections`
- Anonymous method syntax (assuming anonymous methods are enabled): `self.{...}`, `self.(...) {...}`, `self.=> ...`, `self.(...) => ...`
- `self ?? ...` (e.g., `self ?? (throw ...)` promotes `self` to non-nullable in the code that follows)
Not sure how important it is to detect all of these (the `self ?? (throw ...)` case is particularly obscure), so your call whether to add more checks.
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Jul 27, 2026, 2:08:14 PM (10 days ago) Jul 27
to Brian Wilkerson, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 27, 2026, 2:41:08 PM (10 days ago) Jul 27
to Brian Wilkerson, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add a lint to flag local variables created to promote `this`.
I think this covers the behavior outlined in the doc, but please check
to see whether I missed any cases that either should or shouldn't be
reported.
Change-Id: I21d1156e7d54a0944a7e3b1982b9fb54cc3d9032
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/527400
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
- M pkg/linter/lib/src/diagnostic.g.dart
- M pkg/linter/lib/src/lint_names.g.dart
- M pkg/linter/lib/src/rules.dart
- A pkg/linter/lib/src/rules/unnecessary_this_alias.dart
- M pkg/linter/messages.yaml
- M pkg/linter/test/rules/all.dart
- A pkg/linter/test/rules/unnecessary_this_alias_test.dart
Change size: L
Delta: 8 files changed, 468 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Aug 5, 2026, 7:53:40 PM (8 hours ago) Aug 5
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
File pkg/linter/lib/src/rules/unnecessary_this_alias.dart
I thought of a few other expressions that can promote too:
- `self?.property` (e.g., `self?.x = self.y`)
- `self?.method(...)` (e.g., `self?.f(self.x)`)
- `self?[...]` (e.g., `self?[self.x]` or `self?[self.x] = self.y`
- `self?..cascadeSections`
- Anonymous method syntax (assuming anonymous methods are enabled): `self.{...}`, `self.(...) {...}`, `self.=> ...`, `self.(...) => ...`
- `self ?? ...` (e.g., `self ?? (throw ...)` promotes `self` to non-nullable in the code that follows)
Not sure how important it is to detect all of these (the `self ?? (throw ...)` case is particularly obscure), so your call whether to add more checks.
Brian Wilkerson
Addressed by https://dart-review.googlesource.com/c/sdk/+/532320.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages