[XL] Change in dart/sdk[main]: Add tests about private collision

6 views
Skip to first unread message

Lasse Nielsen (Gerrit)

unread,
Jun 17, 2022, 4:07:22 AM6/17/22
to Erik Ernst, rev...@dartlang.org, Dart CI, Commit Bot

Attention is currently required from: Erik Ernst.

Patch set 7:Code-Review +1

View Change

1 comment:

  • File tests/language/private/private_collision_error_test.dart:

    • Patch Set #6, Line 143: // [analyzer] COMPILE_TIME_ERROR.PRIVATE_COLLISION_IN_MIXIN_APPLICATION

      Yes, and even an abstract one.

      Ack

To view, visit change 199247. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie18a7999a02458b3892e83bb2dde6d79b62c811d
Gerrit-Change-Number: 199247
Gerrit-PatchSet: 7
Gerrit-Owner: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
Gerrit-CC: Commit Bot <commi...@chromium.org>
Gerrit-Attention: Erik Ernst <eer...@google.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 08:07:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Lasse Nielsen <l...@google.com>
Comment-In-Reply-To: Erik Ernst <eer...@google.com>
Gerrit-MessageType: comment
Reply all
Reply to author
Forward
0 new messages