[L] Change in dart/sdk[main]: [cfe] Add support for primary constructors on enums

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Oct 30, 2025, 7:32:44 AM (2 days ago) Oct 30
to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Johnni Winther voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1d380b296bf1b4f37d9a05f02bf1945d160294c4
Gerrit-Change-Number: 458220
Gerrit-PatchSet: 4
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Kallen Tu <kall...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 11:32:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Oct 30, 2025, 12:28:23 PM (2 days ago) Oct 30
to Johnni Winther, Kallen Tu, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1d380b296bf1b4f37d9a05f02bf1945d160294c4
Gerrit-Change-Number: 458220
Gerrit-PatchSet: 4
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Kallen Tu <kall...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 16:28:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Oct 31, 2025, 6:01:48 AM (22 hours ago) Oct 31
to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org

Johnni Winther voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1d380b296bf1b4f37d9a05f02bf1945d160294c4
Gerrit-Change-Number: 458220
Gerrit-PatchSet: 5
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Kallen Tu <kall...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 10:01:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Oct 31, 2025, 6:53:44 AM (21 hours ago) Oct 31
to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Fri, 31 Oct 2025 10:53:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Oct 31, 2025, 7:52:08 AM (20 hours ago) Oct 31
to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Fri, 31 Oct 2025 11:52:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Oct 31, 2025, 10:12:01 AM (18 hours ago) Oct 31
to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org

Johnni Winther submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[cfe] Add support for primary constructors on enums

Part of https://github.com/dart-lang/sdk/issues/61700
Change-Id: I1d380b296bf1b4f37d9a05f02bf1945d160294c4
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Files:
  • M pkg/front_end/lib/src/source/outline_builder.dart
  • M pkg/front_end/lib/src/source/source_enum_builder.dart
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart.strong.expect
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart.strong.modular.expect
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart.strong.outline.expect
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart.strong.transformed.expect
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart.textual_outline.expect
  • A pkg/front_end/testcases/declaring_constructors/enum_primary_constructor.dart.textual_outline_modelled.expect
Change size: L
Delta: 9 files changed, 394 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1d380b296bf1b4f37d9a05f02bf1945d160294c4
Gerrit-Change-Number: 458220
Gerrit-PatchSet: 6
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages