[M] Change in dart/sdk[main]: [test] Change the `record_use` tests to semantic equality
0 views
Skip to first unread message
Daco Harkes (Gerrit)
Dec 23, 2025, 5:39:01 AM (yesterday) Dec 23
to Srujan Gaddam, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Srujan Gaddam
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Srujan Gaddam
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Srujan Gaddam (Gerrit)
Dec 23, 2025, 12:17:59 PM (yesterday) Dec 23
to Daco Harkes, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes
Srujan Gaddam voted and added 1 comment![]( "Open in Gerrit")
Votes added by Srujan Gaddam
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Dec 23, 2025, 12:22:25 PM (yesterday) Dec 23
to Srujan Gaddam, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Daco Harkes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daco Harkes
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 23, 2025, 12:22:40 PM (yesterday) Dec 23
to Daco Harkes, Srujan Gaddam, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[test] Change the `record_use` tests to semantic equality
Testing for semantic equality means that we don't have to update
the expectation files every time a backwards compatible change to the
json serialization rolls in.
This also i a step towards being able to share the expect files
between the VM and dart2js.
Bug: https://github.com/dart-lang/native/issues/2885
TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dartdev/test/native_assets/compile_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart
For reference, to update the goldens:
```
$ tools/test.py -m release --vm-options -DupdateExpectations=true pkg/vm/test/transformations/record_use && \
tools/test.py -m release --vm-options -DupdateExpectations=true pkg/compiler/test/record_use/record_use
```
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-linux-chrome-try,dart2js-unit-linux-x64-release-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try
Change-Id: I462350909eb82f486d09b813f2bc516fe50ce0fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469580
Reviewed-by: Srujan Gaddam <sru...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Files:
- M pkg/compiler/test/record_use/record_use_test.dart
- M pkg/dartdev/pubspec.yaml
- M pkg/dartdev/test/native_assets/compile_test.dart
- M pkg/vm/test/transformations/record_use_test.dart
Change size: M
Delta: 4 files changed, 70 insertions(+), 99 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Srujan Gaddam
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages