[S] Change in dart/sdk[main]: [DAS] Adds private type test to `Add type annotation` fix tests

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Sep 23, 2025, 11:57:22 PM (6 days ago) Sep 23
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Adds private type test to `Add type annotation` fix tests

Copying the same test from the assist tests to the fix tests. This is solely to make sure we know this is covered by looking at that file only. A small but important information that I believe is worth having duplicated.
Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072

Change information

Files:
  • M pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
  • M pkg/analysis_server/test/src/services/correction/fix/add_type_annotation_test.dart
Change size: S
Delta: 2 files changed, 25 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072
Gerrit-Change-Number: 451127
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Sep 23, 2025, 11:58:58 PM (6 days ago) Sep 23
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel added 1 comment

File pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
Line 851, Patchset 1 (Parent): // This is now failing because we're suggesting "List" rather than nothing.
Felipe Morschel . resolved

This comment is outdated since https://github.com/dart-lang/sdk/commit/7c754d325de87ef4c91246476f62f96ec2db4808 but was not rewritten then.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072
Gerrit-Change-Number: 451127
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 24 Sep 2025 03:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Sep 25, 2025, 12:16:33 AM (5 days ago) Sep 25
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Felipe Morschel
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072
Gerrit-Change-Number: 451127
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Thu, 25 Sep 2025 04:16:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Sep 26, 2025, 1:49:24 PM (3 days ago) Sep 26
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Brian Wilkerson voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072
    Gerrit-Change-Number: 451127
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 17:49:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Sep 26, 2025, 2:16:22 PM (3 days ago) Sep 26
    to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [DAS] Adds private type test to `Add type annotation` fix tests

    Copying the same test from the assist tests to the fix tests. This is solely to make sure we know this is covered by looking at that file only. A small but important information that I believe is worth having duplicated.
    Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Commit-Queue: Brian Wilkerson <brianwi...@google.com>
    Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
    Files:
    • M pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
    • M pkg/analysis_server/test/src/services/correction/fix/add_type_annotation_test.dart
    Change size: S
    Delta: 2 files changed, 25 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Brian Wilkerson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I0c5bc4843d9eb6a5f2fb37945392d6c6f5186072
    Gerrit-Change-Number: 451127
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages