[XS] Change in dart/sdk[main]: Fix DART_TARGET_OS_WINDOWS define

0 views
Skip to first unread message

Ivan Inozemtsev (Gerrit)

unread,
12:14 PM (7 hours ago) 12:14 PM
to Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Ivan Inozemtsev voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37f9f3b98a2bf1fc6c7e9c9828aa22c8d77d2f58
Gerrit-Change-Number: 531401
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 16:14:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
12:20 PM (7 hours ago) 12:20 PM
to Ivan Inozemtsev, Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ivan Inozemtsev

Alexander Markov voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ivan Inozemtsev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37f9f3b98a2bf1fc6c7e9c9828aa22c8d77d2f58
Gerrit-Change-Number: 531401
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Attention: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 16:20:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ivan Inozemtsev (Gerrit)

unread,
12:23 PM (7 hours ago) 12:23 PM
to Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Ivan Inozemtsev voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I37f9f3b98a2bf1fc6c7e9c9828aa22c8d77d2f58
    Gerrit-Change-Number: 531401
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ivan Inozemtsev <iinoz...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
    Gerrit-Attention: Alexander Markov <alexm...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 16:23:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages