[M] Change in dart/sdk[main]: [modular_aot] _List default factory constructor

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
12:59 PM (6 hours ago) 12:59 PM
to Alexander Markov, Slava Egorov, Alexander Aprelev, Nate Biggs, Tess Strickland, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Slava Egorov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7930623a7787707ead1ebf85af3469cf2ad53
Gerrit-Change-Number: 531740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 16:59:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
4:18 PM (3 hours ago) 4:18 PM
to Alexander Markov, Alexander Aprelev, Nate Biggs, Tess Strickland, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Alexander Markov

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7930623a7787707ead1ebf85af3469cf2ad53
Gerrit-Change-Number: 531740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 20:18:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
5:10 PM (2 hours ago) 5:10 PM
to Alexander Markov, Slava Egorov, Alexander Aprelev, Nate Biggs, Tess Strickland, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Alexander Markov voted and added 1 comment

Votes added by Alexander Markov

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Markov . resolved

Thanks Slava!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7930623a7787707ead1ebf85af3469cf2ad53
Gerrit-Change-Number: 531740
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 21:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
5:49 PM (1 hour ago) 5:49 PM
to Alexander Markov, Slava Egorov, Alexander Aprelev, Nate Biggs, Tess Strickland, Nicholas Shahan, Stephen Adams, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[modular_aot] _List default factory constructor
Change-Id: Ia7d7930623a7787707ead1ebf85af3469cf2ad53
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
  • M pkg/cfg/lib/ir/flow_graph_builder.dart
  • M pkg/cfg/lib/ir/flow_graph_checker.dart
  • M pkg/cfg/lib/ir/instructions.dart
  • M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
  • M pkg/native_compiler/lib/back_end/arm64/constraints.dart
  • M pkg/native_compiler/lib/front_end/recognized_methods.dart
  • M pkg/native_compiler/lib/passes/lowering.dart
Change size: M
Delta: 7 files changed, 61 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ia7d7930623a7787707ead1ebf85af3469cf2ad53
Gerrit-Change-Number: 531740
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages