[XL] Change in dart/sdk[main]: [deps] Roll dart-lang/native

0 views
Skip to first unread message

Daco Harkes (Gerrit)

unread,
Dec 19, 2025, 3:56:58 AM (3 days ago) Dec 19
to Moritz Sümmermann, Commit Queue, rev...@dartlang.org
Attention needed from Moritz Sümmermann

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Moritz Sümmermann
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3b4209b8952a0c86017fdc26c0e2351ba78a8f72
Gerrit-Change-Number: 469060
Gerrit-PatchSet: 7
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Moritz Sümmermann <mo...@google.com>
Gerrit-Attention: Moritz Sümmermann <mo...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 08:56:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mayank Patke (Gerrit)

unread,
Dec 19, 2025, 4:42:55 AM (3 days ago) Dec 19
to Daco Harkes, Moritz Sümmermann, Commit Queue, rev...@dartlang.org
Attention needed from Daco Harkes and Moritz Sümmermann

Mayank Patke voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daco Harkes
  • Moritz Sümmermann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3b4209b8952a0c86017fdc26c0e2351ba78a8f72
Gerrit-Change-Number: 469060
Gerrit-PatchSet: 8
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Mayank Patke <fishyt...@google.com>
Gerrit-Reviewer: Moritz Sümmermann <mo...@google.com>
Gerrit-Attention: Moritz Sümmermann <mo...@google.com>
Gerrit-Attention: Daco Harkes <dacoh...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:42:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daco Harkes (Gerrit)

unread,
Dec 19, 2025, 5:12:30 AM (2 days ago) Dec 19
to Mayank Patke, Moritz Sümmermann, Commit Queue, rev...@dartlang.org
Attention needed from Moritz Sümmermann

Daco Harkes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Moritz Sümmermann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3b4209b8952a0c86017fdc26c0e2351ba78a8f72
Gerrit-Change-Number: 469060
Gerrit-PatchSet: 8
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Mayank Patke <fishyt...@google.com>
Gerrit-Reviewer: Moritz Sümmermann <mo...@google.com>
Gerrit-Attention: Moritz Sümmermann <mo...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 10:12:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 19, 2025, 5:12:45 AM (2 days ago) Dec 19
to Daco Harkes, Mayank Patke, Moritz Sümmermann, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[deps] Roll dart-lang/native

The new record_use serializer orders keys alphabetically, the files
are staying the same length in lines.

Note: In a later PR we should update the golden files to be identical
between both compilers to ensure correctness across the compilers.

TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dartdev/test/native_assets/*_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart
Change-Id: I3b4209b8952a0c86017fdc26c0e2351ba78a8f72
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try
Reviewed-by: Mayank Patke <fishyt...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Files:
  • M DEPS
  • M pkg/compiler/test/record_use/golden/basic.json.expect
  • M pkg/compiler/test/record_use/golden/complex.json.expect
  • M pkg/compiler/test/record_use/golden/different.json.expect
  • M pkg/compiler/test/record_use/golden/extension.json.expect
  • M pkg/compiler/test/record_use/golden/instance_class.json.expect
  • M pkg/compiler/test/record_use/golden/instance_complex.json.expect
  • M pkg/compiler/test/record_use/golden/instance_duplicates.json.expect
  • M pkg/compiler/test/record_use/golden/instance_method.json.expect
  • M pkg/compiler/test/record_use/golden/instance_not_annotation.json.expect
  • M pkg/compiler/test/record_use/golden/loading_units_multiple.json.expect
  • M pkg/compiler/test/record_use/golden/loading_units_simple.json.expect
  • M pkg/compiler/test/record_use/golden/named_and_positional.json.expect
  • M pkg/compiler/test/record_use/golden/named_both.json.expect
  • M pkg/compiler/test/record_use/golden/named_optional.json.expect
  • M pkg/compiler/test/record_use/golden/named_required.json.expect
  • M pkg/compiler/test/record_use/golden/nested.json.expect
  • M pkg/compiler/test/record_use/golden/partfile_main.json.expect
  • M pkg/compiler/test/record_use/golden/positional_both.json.expect
  • M pkg/compiler/test/record_use/golden/positional_optional.json.expect
  • M pkg/compiler/test/record_use/golden/record_enum.json.expect
  • M pkg/compiler/test/record_use/golden/record_instance_constant_empty.json.expect
  • M pkg/compiler/test/record_use/golden/simple.json.expect
  • M pkg/compiler/test/record_use/golden/tearoff.json.expect
  • M pkg/compiler/test/record_use/golden/top_level_method.json.expect
  • M pkg/compiler/test/record_use/golden/types_of_arguments.json.expect
  • M pkg/dartdev/test/native_assets/compile_test.dart
  • M pkg/vm/testcases/transformations/record_use/complex.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/extension.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/instance_class.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/instance_complex.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/instance_duplicates.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/instance_method.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/instance_not_annotation.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/loading_units_multiple.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/loading_units_simple.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/named_and_positional.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/named_both.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/named_optional.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/named_required.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/named_with_function_arg.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/nested.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/partfile_main.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/positional_both.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/positional_optional.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/record_enum.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/record_instance_constant_empty.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/simple.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/tearoff.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/top_level_method.dart.json.expect
  • M pkg/vm/testcases/transformations/record_use/types_of_arguments.dart.json.expect
Change size: XL
Delta: 51 files changed, 922 insertions(+), 922 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mayank Patke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3b4209b8952a0c86017fdc26c0e2351ba78a8f72
Gerrit-Change-Number: 469060
Gerrit-PatchSet: 9
Gerrit-Owner: Daco Harkes <dacoh...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages