[XS] Change in dart/sdk[main]: Update webdev pin

Anna Gringauze (Gerrit)

unread,

Oct 31, 2023, 8:45:02 PM10/31/23

to Nicholas Shahan, Elliott Brooks, rev...@dartlang.org

Attention is currently required from: Elliott Brooks, Nicholas Shahan.

Anna Gringauze would like Nicholas Shahan and Elliott Brooks to review this change.

Update webdev pin

Pins DWDS to https://github.com/dart-lang/webdev/commit/5ad79c240b000a50057612d6af4573f6e649f65c
which is necessary to unblock Dwds rolls due to this change to the LoadStragegy interface:

https://github.com/dart-lang/webdev/pull/2270, which is a breaking change to google3.

Change-Id: I24fe79315b8493103c6b00e96f4fcea1ee011231
---
M DEPS
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DEPS b/DEPS
index 70eeb53..65407b8 100644
--- a/DEPS
+++ b/DEPS
@@ -193,7 +193,7 @@
   "vector_math_rev": "294896dedc6da2a736f47c3c6a19643df934641c",
   "watcher_rev": "6ad58dcbbf328fbecf18d6ad2357c67be300b489",
   "web_socket_channel_rev": "f3ac1bf2bd3c93eb6d5d78646ff7de31797f4cf6",
-  "webdev_rev": "50534a1299d1fdcac065ac337abcad26886ff029",
+  "webdev_rev": "5ad79c240b000a50057612d6af4573f6e649f65c", # https://github.com/dart-lang/webdev/issues/2276
   "webdriver_rev": "eaf9c582e6e72c3551d3a875b2d522cd1ad06593",
   "webkit_inspection_protocol_rev": "82f0c1c46dfdba5edf7c5fa84456233121dd69e1",
   "yaml_rev": "9f0d64934c07bc27438074616455618b7103582d",

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

Anna Gringauze (Gerrit)

unread,

Oct 31, 2023, 8:51:34 PM10/31/23

to rev...@dartlang.org

Attention is currently required from: Anna Gringauze, Elliott Brooks, Nicholas Shahan.

Anna Gringauze uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Commit-Queue+1 by Anna Gringauze

Update webdev pin

Pins DWDS to https://github.com/dart-lang/webdev/commit/5ad79c240b000a50057612d6af4573f6e649f65c
which is necessary to unblock Dwds rolls due to this change to the LoadStragegy interface:

https://github.com/dart-lang/webdev/pull/2270, which is a breaking change to google3.

Towards: https://github.com/dart-lang/webdev/issues/2276



Change-Id: I24fe79315b8493103c6b00e96f4fcea1ee011231
---
M DEPS
1 file changed, 1 insertion(+), 1 deletion(-)

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

CBuild (Gerrit)

unread,

Oct 31, 2023, 9:21:35 PM10/31/23

to Anna Gringauze, rev...@dartlang.org, Commit Queue, Elliott Brooks, Nicholas Shahan

Attention is currently required from: Anna Gringauze, Elliott Brooks, Nicholas Shahan.

go/dart-cbuild result: SUCCESS

Details: https://goto.google.com/dart-cbuild/find/0dc6beb3394205a2f93fe91c7b3584e909a04238

View Change

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

Nicholas Shahan (Gerrit)

unread,

Nov 1, 2023, 11:34:07 AM11/1/23

to Anna Gringauze, rev...@dartlang.org, CBuild, Commit Queue, Elliott Brooks

Attention is currently required from: Anna Gringauze, Elliott Brooks.

Patch set 2:Code-Review +1

View Change

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

Anna Gringauze (Gerrit)

unread,

Nov 1, 2023, 12:38:09 PM11/1/23

to rev...@dartlang.org, Nicholas Shahan, CBuild, Commit Queue, Elliott Brooks

Attention is currently required from: Elliott Brooks.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

Commit Queue (Gerrit)

unread,

Nov 1, 2023, 12:38:30 PM11/1/23

to Anna Gringauze, rev...@dartlang.org, Nicholas Shahan, CBuild, Elliott Brooks

Commit Queue submitted this change.

View Change

Approvals:
  Nicholas Shahan: Looks good to me, approved
  Anna Gringauze: Commit

Update webdev pin

Pins DWDS to https://github.com/dart-lang/webdev/commit/5ad79c240b000a50057612d6af4573f6e649f65c
which is necessary to unblock Dwds rolls due to this change to the LoadStragegy interface:

https://github.com/dart-lang/webdev/pull/2270, which is a breaking change to google3.

Towards: https://github.com/dart-lang/webdev/issues/2276

Change-Id: I24fe79315b8493103c6b00e96f4fcea1ee011231

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333123
Reviewed-by: Nicholas Shahan <nsh...@google.com>
Commit-Queue: Anna Gringauze <anna...@google.com>


---
M DEPS
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DEPS b/DEPS
index 70eeb53..65407b8 100644
--- a/DEPS
+++ b/DEPS
@@ -193,7 +193,7 @@
   "vector_math_rev": "294896dedc6da2a736f47c3c6a19643df934641c",
   "watcher_rev": "6ad58dcbbf328fbecf18d6ad2357c67be300b489",
   "web_socket_channel_rev": "f3ac1bf2bd3c93eb6d5d78646ff7de31797f4cf6",
-  "webdev_rev": "50534a1299d1fdcac065ac337abcad26886ff029",
+  "webdev_rev": "5ad79c240b000a50057612d6af4573f6e649f65c", # https://github.com/dart-lang/webdev/issues/2276
   "webdriver_rev": "eaf9c582e6e72c3551d3a875b2d522cd1ad06593",
   "webkit_inspection_protocol_rev": "82f0c1c46dfdba5edf7c5fa84456233121dd69e1",
   "yaml_rev": "9f0d64934c07bc27438074616455618b7103582d",

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

CBuild (Gerrit)

unread,

Nov 1, 2023, 1:08:18 PM11/1/23

to Commit Queue, Anna Gringauze, rev...@dartlang.org, Nicholas Shahan, Elliott Brooks

go/dart-cbuild result: SUCCESS

Details: https://goto.google.com/dart-cbuild/find/e20ccee8a1bfa2335fedda104cc9ff6c9b3a79ab

View Change

To view, visit change 333123. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward