[S] Change in dart/sdk[main]: linter: collection_methods_unrelated_type: Null not related to non-nu...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
May 6, 2026, 10:32:59 AM (7 days ago) May 6
to Samuel Rawlins, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
May 6, 2026, 4:02:12 PM (7 days ago) May 6
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
10:03 AM (2 hours ago) 10:03 AM
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linter: collection_methods_unrelated_type: Null not related to non-nullable
Fixes https://github.com/dart-lang/sdk/issues/57101
This change affects collection_methods_unrelated_type and
unrelated_type_equality_checks. For example these are now reported:
```dart
void f(Set<String> p1, int p2) {
p1.contains(null);
p2 == null;
}
```
Change-Id: Ib58bad2beb6b9df8fe7c71f27213055e9b8d5cb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/489481
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/linter/lib/src/util/dart_type_utilities.dart
- M pkg/linter/test/rules/collection_methods_unrelated_type_test.dart
Change size: S
Delta: 2 files changed, 38 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages