[M] Change in dart/sdk[main]: [vm/shared] Maintain visited set when assessing immutability in closu...

0 views

Skip to first unread message

Ryan Macnak (Gerrit)

unread,

Dec 9, 2025, 12:47:22 PM12/9/25

to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Attention needed from Alexander Aprelev

Ryan Macnak voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Alexander Aprelev

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alexander Aprelev (Gerrit)

unread,

Dec 10, 2025, 11:45:34 AM12/10/25

to Alexander Aprelev, Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Alexander Aprelev voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Commit Queue (Gerrit)

unread,

Dec 10, 2025, 12:19:08 PM12/10/25

to Alexander Aprelev, Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[vm/shared] Maintain visited set when assessing immutability in closures.

Fixes https://github.com/dart-lang/sdk/issues/62178
TEST=run_isolate_group_run_test

Change-Id: Ia722ef6417e5cf2506bbc70d55299ce1ec04d13f

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/466842

Commit-Queue: Alexander Aprelev <a...@google.com>

Reviewed-by: Ryan Macnak <rma...@google.com>

Files:

M runtime/vm/ffi_callback_metadata.cc
M tests/ffi/run_isolate_group_run_test.dart

Change size: M

Delta: 2 files changed, 70 insertions(+), 7 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ryan Macnak

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages